Issue 54000043: code review 54000043: syscall: fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 54000043: code review 54000043: syscall: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by mikio

Modified:
11 years, 5 months ago

Reviewers:
r, iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

syscall: fix build

Patch Set 1 : diff -r a2851f84e24e https://code.google.com/p/go #

Patch Set 2 : diff -r a2851f84e24e https://code.google.com/p/go #

Patch Set 3 : diff -r a2851f84e24e https://code.google.com/p/go #

Total comments: 2

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	src/pkg/syscall/rlimit_unix_test.go	View	1	2 chunks	+9 lines, -1 line	2 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

mikio

Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 5 months ago (2014-01-18 01:06:12 UTC) #1

iant

Setting up a function literal that you only call in one place seems a bit ...

11 years, 5 months ago (2014-01-18 01:32:01 UTC) #2

mikio

Hello golang-codereviews@googlegroups.com, iant@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.

11 years, 5 months ago (2014-01-18 02:00:43 UTC) #3

mikio

*** Submitted as https://code.google.com/p/go/source/detail?r=c386e6de4f5c *** syscall: fix build R=golang-codereviews, iant CC=golang-codereviews https://codereview.appspot.com/54000043

11 years, 5 months ago (2014-01-18 02:22:41 UTC) #5

11 years, 5 months ago (2014-01-18 02:27:15 UTC) #6

Message was sent while issue was closed.

https://codereview.appspot.com/54000043/diff/80001/src/pkg/syscall/rlimit_uni...
File src/pkg/syscall/rlimit_unix_test.go (right):

https://codereview.appspot.com/54000043/diff/80001/src/pkg/syscall/rlimit_uni...
src/pkg/syscall/rlimit_unix_test.go:39: // increse the soft limit of rlimit
sandbox, though
s/increse/increase/

https://codereview.appspot.com/54000043/diff/80001/src/pkg/syscall/rlimit_uni...
src/pkg/syscall/rlimit_unix_test.go:40: // Setrlimit never reports error.
s/error/an &/

Expand All Messages | Collapse All Messages