Issue 53820046: code review 53820046: cmd/gc, cmd/ld: fix Plan 9 warnings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 53820046: code review 53820046: cmd/gc, cmd/ld: fix Plan 9 warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by 0intro

Modified:
11 years, 1 month ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

cmd/gc, cmd/ld: fix Plan 9 warnings warning: /usr/go/src/cmd/gc/obj.c:23 format mismatch -10d VLONG, arg 9 warning: /usr/go/src/cmd/gc/plive.c:1680 set and not used: printed warning: /usr/go/src/cmd/ld/lib.c:332 non-interruptable temporary warning: /usr/go/src/cmd/ld/lib.c:338 non-interruptable temporary

Patch Set 1 #

Patch Set 2 : diff -r 2a595fd8c22b https://code.google.com/p/go #

Patch Set 3 : diff -r 2a595fd8c22b https://code.google.com/p/go #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
M	src/cmd/gc/obj.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/plive.c	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/cmd/ld/lib.c	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

0intro

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 1 month ago (2014-01-22 19:35:53 UTC) #1

0intro

11 years, 1 month ago (2014-01-22 20:21:27 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=b7360907d178 ***

cmd/gc, cmd/ld: fix Plan 9 warnings

warning: /usr/go/src/cmd/gc/obj.c:23 format mismatch -10d VLONG, arg 9
warning: /usr/go/src/cmd/gc/plive.c:1680 set and not used: printed
warning: /usr/go/src/cmd/ld/lib.c:332 non-interruptable temporary
warning: /usr/go/src/cmd/ld/lib.c:338 non-interruptable temporary

R=rsc
CC=golang-codereviews
https://codereview.appspot.com/53820046

Expand All Messages | Collapse All Messages