Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1468)

Issue 5373041: Fold set-time-signature into \time (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by dak
Modified:
7 years, 7 months ago
Reviewers:
pkx166h
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fold set-time-signature into \time This removes the strange-syntax set-time-signature and folds its functionality into \time, by admitting beat-structure as an optional argument before the signature. There are several patches in the series: Run scripts/auxiliar/update-with-convert-ly.sh Fold set-time-signature into \time Make new predicate number-list? I decided to move make-time-signature-set into the music function definition. There is a function with the same name and a previous life-span in the load-order that just sufficed for getting its function value copied into some internal property before getting overwritten. Amazing that this did not explode long ago. This patch is on top of Issue 2024, I'll block it on it accordingly. It will also be blocked until VERSION increases enough to make Lilypond happy about the results of convert-ly.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -52 lines) Patch
M Documentation/snippets/conducting-signs,-measure-grouping-signs.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/heavily-customized-polymetric-time-signatures.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly View 3 chunks +9 lines, -10 lines 0 comments Download
M input/regression/display-lily-tests.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/measure-grouping.ly View 2 chunks +4 lines, -4 lines 0 comments Download
M ly/music-functions-init.ly View 1 chunk +8 lines, -3 lines 0 comments Download
M python/convertrules.py View 3 chunks +23 lines, -10 lines 0 comments Download
M scm/c++.scm View 1 chunk +3 lines, -0 lines 0 comments Download
M scm/define-music-display-methods.scm View 1 chunk +2 lines, -2 lines 0 comments Download
M scm/lily.scm View 1 chunk +1 line, -0 lines 0 comments Download
M scm/music-functions.scm View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 1
pkx166h
7 years, 7 months ago (2011-11-12 01:38:06 UTC) #1
Passes make and one reg test shows up

http://code.google.com/p/lilypond/issues/detail?id=2032#c6

James
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b