Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1591)

Issue 53720043: code review 53720043: doc: replace "private" with "unexported" in Effective Go. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by dsymonds
Modified:
11 years, 4 months ago
Reviewers:
r
CC:
golang-codereviews
Visibility:
Public.

Description

doc: replace "private" with "unexported" in Effective Go.

Patch Set 1 #

Patch Set 2 : diff -r c22889382a17 https://code.google.com/p/go #

Patch Set 3 : diff -r c22889382a17 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r c22889382a17 https://code.google.com/p/go #

Patch Set 5 : diff -r 35e2da254287 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M doc/effective_go.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
dsymonds
Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 4 months ago (2014-01-17 16:22:44 UTC) #1
r
https://codereview.appspot.com/53720043/diff/40001/doc/effective_go.html File doc/effective_go.html (right): https://codereview.appspot.com/53720043/diff/40001/doc/effective_go.html#newcode291 doc/effective_go.html:291: Even for unexported names, grouping can also indicate relationships ...
11 years, 4 months ago (2014-01-17 16:50:02 UTC) #2
r
https://codereview.appspot.com/53720043/diff/40001/doc/effective_go.html File doc/effective_go.html (right): https://codereview.appspot.com/53720043/diff/40001/doc/effective_go.html#newcode291 doc/effective_go.html:291: Even for unexported names, grouping can also indicate relationships ...
11 years, 4 months ago (2014-01-17 16:52:11 UTC) #3
dsymonds
On 17 January 2014 08:52, <r@golang.org> wrote: > or you could just drop it altogether: ...
11 years, 4 months ago (2014-01-17 17:04:13 UTC) #4
dsymonds
*** Submitted as https://code.google.com/p/go/source/detail?r=03ec05bfd116 *** doc: replace "private" with "unexported" in Effective Go. R=r CC=golang-codereviews ...
11 years, 4 months ago (2014-01-17 17:06:43 UTC) #5
r
LGTM The usual protocol is to receive the LGTM before submitting.
11 years, 4 months ago (2014-01-17 17:13:12 UTC) #6
r
It's also a good idea to update the CL when it becomes inaccurate.
11 years, 4 months ago (2014-01-17 17:14:03 UTC) #7
dsymonds
11 years, 4 months ago (2014-01-17 17:18:04 UTC) #8
Sorry, mixed up CLs. I thought you had LGTM'd. My mistake.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b