Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(97)

Issue 53690043: code review 53690043: syscall: make getrlimit, setrlimit tests work on unix v... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by mikio
Modified:
11 years, 5 months ago
Reviewers:
iant
CC:
golang-codereviews, iant
Visibility:
Public.

Description

syscall: make getrlimit, setrlimit tests work on unix variants

Patch Set 1 : diff -r 322f646feecb https://code.google.com/p/go #

Patch Set 2 : diff -r 10e099e6ab49 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/pkg/syscall/rlimit_unix_test.go View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
mikio
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 5 months ago (2014-01-17 13:53:12 UTC) #1
iant
I don't understand--there is no such file as far as I can see. I see ...
11 years, 5 months ago (2014-01-17 14:33:00 UTC) #2
mikio
> I don't understand--there is no such file as far as I can see. I ...
11 years, 5 months ago (2014-01-17 14:41:58 UTC) #3
iant
LGTM Sorry, the file rename does not seem to show up on codereview.appspot.com. Or at ...
11 years, 5 months ago (2014-01-17 15:19:42 UTC) #4
mikio
11 years, 5 months ago (2014-01-17 23:34:39 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=a2851f84e24e ***

syscall: make getrlimit, setrlimit tests work on unix variants

R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/53690043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b