http://codereview.appspot.com/5345042/diff/3001/tests/gdata_tests/apps/multidomain/live_client_test.py File tests/gdata_tests/apps/multidomain/live_client_test.py (right): http://codereview.appspot.com/5345042/diff/3001/tests/gdata_tests/apps/multidomain/live_client_test.py#newcode150 tests/gdata_tests/apps/multidomain/live_client_test.py:150: print fetched_aliases.entry[0].user_email, fetched_aliases.entry[0].alias_email Was this used for debug? Remove ...
12 years, 5 months ago
(2011-11-04 16:41:32 UTC)
#3
12 years, 5 months ago
(2011-11-07 17:10:04 UTC)
#7
http://codereview.appspot.com/5345042/diff/3001/tests/gdata_tests/apps/multid...
File tests/gdata_tests/apps/multidomain/live_client_test.py (right):
http://codereview.appspot.com/5345042/diff/3001/tests/gdata_tests/apps/multid...
tests/gdata_tests/apps/multidomain/live_client_test.py:150: print
fetched_aliases.entry[0].user_email, fetched_aliases.entry[0].alias_email
On 2011/11/07 12:09:58, gunjansharma wrote:
> On 2011/11/04 16:41:33, Claudio Cherubino wrote:
> > Was this used for debug? Remove it
> When you rename the username the old one becomes a Alias for the user.
I don't see why you should print that to the standard output. Tests shouldn't
use print directly and I'd just remove this line
http://codereview.appspot.com/5345042/diff/3001/tests/gdata_tests/apps/multid...
tests/gdata_tests/apps/multidomain/live_client_test.py:154:
self.assertEquals(fetched_aliases.entry[1].alias_email, alias)
On 2011/11/07 12:09:58, gunjansharma wrote:
> On 2011/11/04 16:41:33, Claudio Cherubino wrote:
> > who guarantees you have two aliases here? I only see one createAlias call
> Same argument as above.
Makes sense, thanks for reminding me.
12 years, 5 months ago
(2011-11-08 05:23:27 UTC)
#9
http://codereview.appspot.com/5345042/diff/3001/tests/gdata_tests/apps/multid...
File tests/gdata_tests/apps/multidomain/live_client_test.py (right):
http://codereview.appspot.com/5345042/diff/3001/tests/gdata_tests/apps/multid...
tests/gdata_tests/apps/multidomain/live_client_test.py:150: print
fetched_aliases.entry[0].user_email, fetched_aliases.entry[0].alias_email
On 2011/11/07 17:10:04, Claudio Cherubino wrote:
> On 2011/11/07 12:09:58, gunjansharma wrote:
> > On 2011/11/04 16:41:33, Claudio Cherubino wrote:
> > > Was this used for debug? Remove it
> > When you rename the username the old one becomes a Alias for the user.
>
> I don't see why you should print that to the standard output. Tests shouldn't
> use print directly and I'd just remove this line
Done.
Issue 5345042: Changed OAuth scopes for Apps
Created 12 years, 5 months ago by gunjansharma
Modified 12 years, 5 months ago
Reviewers: jcgregorio, Claudio Cherubino
Base URL:
Comments: 7
