code review 53430043: runtime, cmd/gc: Get rid of vararg channel calls.

runtime, cmd/gc: Get rid of vararg channel calls.

Vararg C calls present a problem for the GC because the
argument types are not derivable from the signature.  Remove
them by passing pointers to channel elements instead of the
channel elements directly.

[khr, 2014-01-16 22:55:22]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://khr%40golang.org@code.google.com/p/go/

[gobot, 2014-01-17 00:05:29]

R=rsc@golang.org (assigned by bradfitz@golang.org)

[dvyukov, 2014-01-17 08:58:49]

LGTM for chan.c

Doesn't it affect escape analysis? Doesn't this force heap allocation for values
sent over chans? Doesn't we need to add some special logic to esc.c for
chans/maps?

[rsc, 2014-01-17 14:45:08]

LGTM

To answer Dmitriy's question, escape analysis is not affected because it
analyzes before walk applies the expansions here.

[khr, 2014-01-17 22:48:48]

*** Submitted as https://code.google.com/p/go/source/detail?r=10e099e6ab49 ***

runtime, cmd/gc: Get rid of vararg channel calls.

Vararg C calls present a problem for the GC because the
argument types are not derivable from the signature.  Remove
them by passing pointers to channel elements instead of the
channel elements directly.

R=golang-codereviews, gobot, rsc, dvyukov
CC=golang-codereviews
https://codereview.appspot.com/53430043