Issue 53400043: code review 53400043: time: break parse and formatting tests into a separate ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 53400043: code review 53400043: time: break parse and formatting tests into a separate ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by r

Modified:
11 years, 5 months ago

Reviewers:
iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

time: break parse and formatting tests into a separate source file No changes, just rearrangement. The tests were in need of a little housekeeping.

Patch Set 1 #

Patch Set 2 : diff -r 9c22c9bc4885 https://code.google.com/p/go #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+512 lines, -500 lines)			Patch
	A	src/pkg/time/format_test.go	View		1 chunk	+510 lines, -0 lines	0 comments	Download
	M	src/pkg/time/time_test.go	View		4 chunks	+2 lines, -500 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 5 months ago (2014-01-16 21:39:38 UTC) #1

11 years, 5 months ago (2014-01-16 22:29:20 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=57935890c1da ***

time: break parse and formatting tests into a separate source file
No changes, just rearrangement. The tests were in need of a little
housekeeping.

R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/53400043

Expand All Messages | Collapse All Messages