Issue 5331056: code review 5331056: html: refactor the blacklist for the "render and re-par...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5331056: code review 5331056: html: refactor the blacklist for the "render and re-par... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by nigeltao

Modified:
12 years, 5 months ago

Reviewers:

CC:
andybalholm, golang-dev, MikeSamuel

Visibility:
Public.

Description

html: refactor the blacklist for the "render and re-parse" test.

Patch Set 1 #

Patch Set 2 : diff -r 55b04f0b8f5b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 55b04f0b8f5b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r e953a63b7014 https://go.googlecode.com/hg/ #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -16 lines)			Patch
	M	src/pkg/html/parse_test.go	View	1	2 chunks	+14 lines, -6 lines	0 comments	Download
	M	src/pkg/html/render.go	View	1 2 3	1 chunk	+21 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello andybalholm@gmail.com (cc: golang-dev@googlegroups.com, mikesamuel@gmail.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 5 months ago (2011-11-01 07:50:11 UTC) #1

andybalholm

On 2011/11/01 07:50:11, nigeltao wrote: > I'd like you to review this change to > ...

12 years, 5 months ago (2011-11-01 13:49:46 UTC) #2

nigeltao

12 years, 5 months ago (2011-11-01 22:42:32 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=f26d4fc9845f ***

html: refactor the blacklist for the "render and re-parse" test.

R=andybalholm
CC=golang-dev, mikesamuel
http://codereview.appspot.com/5331056

Expand All Messages | Collapse All Messages