Ninja: substitute RULE_INPUT_PATH and ExpandSpecial for cflags

[tony, 2011-10-24 18:01:28]

This patch looks ok, but can you add a unit test?  There are a bunch of examples
in the test subdir.

[hochhaus, 2011-10-24 20:09:21]

Thanks Tony. I appreciate your help.

I've added a unit test based off the examples you reference and tested that it
passes (on linux).

Can you have another look?

On 2011/10/24 18:01:28, tony wrote:
> This patch looks ok, but can you add a unit test?  There are a bunch of
examples
> in the test subdir.

[tony, 2011-10-24 21:36:01]

This change LGTM.  Can you sign the Google contributor license agreement? 
http://code.google.com/legal/individual-cla-v1.0.html (bottom of the page has an
electronic signature form).  Let me know when you've done it and I'll verify
your name is showing up and commit the patch.

It seems like we should do this expansion for the other generators (msvs, make,
xcode), but this seems fine for now.  Evan can do a more thorough review when he
comes back from sabbatical.

[hochhaus, 2011-10-24 21:47:15]

Thanks Tony.

On Mon, Oct 24, 2011 at 4:36 PM,  <tony@chromium.org> wrote:
> This change LGTM.  Can you sign the Google contributor license
> agreement?  http://code.google.com/legal/individual-cla-v1.0.html
> (bottom of the page has an electronic signature form).  Let me know when
> you've done it and I'll verify your name is showing up and commit the
> patch.

My company I work for (SameGoal, LLC) has previously signed the
corporate CLA when submitting patches to closure-library. The document
we signed is available from:

http://code.google.com/legal/corporate-cla-v1.0.html

We submitted the signed document to cla-submissions@google.com and it
was processed by Daniel Berlin <dannyb@google.com> on 6/23/2010.

In case it is helpful, we are also listed in the AUTHORS file of
closure-library as "SameGoal LLC <help@samegoal.com>":

http://code.google.com/p/closure-library/source/browse/trunk/AUTHORS

> It seems like we should do this expansion for the other generators
> (msvs, make, xcode), but this seems fine for now.  Evan can do a more
> thorough review when he comes back from sabbatical.

I agree. As I get time in the future I hope to setup these other
environments and fix any bugs necessary in order to enable this test
case on those platforms as well. Would you be willing to review such a
change in the future?

Thanks for your very fast help,
-Andy

[tony, 2011-10-24 22:05:12]

Committed in r1082.  Sorry, I forgot to check the corporate cla worksheet.  I
see it now.

I can review Makefile changes, but MSVS and XCode projects should go to others
(you can email the mailing list asking for reviewers).