Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1737)

Issue 5315053: Doc: NR Added new node for Custom Footnotes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by pkx166h
Modified:
7 years, 7 months ago
Reviewers:
Graham Percival, MikeSol, dak, mike
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: NR Added new node for Custom Footnotes This is for Tracker issue 1567

Patch Set 1 #

Total comments: 8

Patch Set 2 : second draft - need help on example for top level markup and autofootnotes #

Total comments: 7

Patch Set 3 : Third Draft with corrections from GP #

Total comments: 16

Patch Set 4 : 4th Draft - more corrections. Thanks Graham. #

Total comments: 9

Patch Set 5 : Draft number 5 - still incomplete though #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -0 lines) Patch
M Documentation/notation/input.itely View 1 2 3 4 2 chunks +210 lines, -0 lines 0 comments Download

Messages

Total messages: 17
pkx166h
There are a few non-standard indents to show more clearly the footnote syntax in the ...
7 years, 8 months ago (2011-10-25 19:30:51 UTC) #1
MikeSol
Thanks for your work on this James! Cheers, MS http://codereview.appspot.com/5315053/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/5315053/diff/1/Documentation/notation/input.itely#newcode1025 Documentation/notation/input.itely:1025: ...
7 years, 8 months ago (2011-10-25 19:36:51 UTC) #2
pkx166h
second draft http://codereview.appspot.com/5315053/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/5315053/diff/1/Documentation/notation/input.itely#newcode1025 Documentation/notation/input.itely:1025: All grobs, top-level @code{\markup} and chorded notes ...
7 years, 8 months ago (2011-10-26 20:21:22 UTC) #3
Graham Percival (old account)
http://codereview.appspot.com/5315053/diff/5001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/5315053/diff/5001/Documentation/notation/input.itely#newcode1020 Documentation/notation/input.itely:1020: There are two types of footnotes that can be ...
7 years, 8 months ago (2011-10-27 01:56:26 UTC) #4
pkx166h
Third Draft. Thanks so far. James http://codereview.appspot.com/5315053/diff/5001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/5315053/diff/5001/Documentation/notation/input.itely#newcode1020 Documentation/notation/input.itely:1020: There are two ...
7 years, 8 months ago (2011-10-29 17:09:11 UTC) #5
Graham Percival
http://codereview.appspot.com/5315053/diff/8001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/5315053/diff/8001/Documentation/notation/input.itely#newcode1019 Documentation/notation/input.itely:1019: technically there should be a 1-2 sentence introduction here. ...
7 years, 7 months ago (2011-10-31 06:37:04 UTC) #6
pkx166h
4th Draft. Thanks Graham. @Mike Solomon: I'd still like an example on how to autofootnote ...
7 years, 7 months ago (2011-11-02 06:10:38 UTC) #7
Graham Percival
http://codereview.appspot.com/5315053/diff/14001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/5315053/diff/14001/Documentation/notation/input.itely#newcode1032 Documentation/notation/input.itely:1032: Automatic footnotes create default superscript numbers which flag the ...
7 years, 7 months ago (2011-11-02 08:17:42 UTC) #8
dak
Oh, by the way, I suggest that you wait for Issue 2003 to go through ...
7 years, 7 months ago (2011-11-02 08:37:11 UTC) #9
MikeSol
http://codereview.appspot.com/5315053/diff/14001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/5315053/diff/14001/Documentation/notation/input.itely#newcode1049 Documentation/notation/input.itely:1049: @qq{bottom left} and @qq{top right} of the grob respectively. ...
7 years, 7 months ago (2011-11-02 09:34:11 UTC) #10
MikeSol
On 2011/11/02 06:10:38, J_lowe wrote: > 4th Draft. Thanks Graham. > > @Mike Solomon: > ...
7 years, 7 months ago (2011-11-02 09:35:54 UTC) #11
dak
> \markup { \auto-footnote a b } Oh. \auto-footnote is a markup command. I haven't ...
7 years, 7 months ago (2011-11-02 09:42:22 UTC) #12
Graham Percival
On Wed, Nov 02, 2011 at 09:34:12AM +0000, mtsolo@gmail.com wrote: > > So that's my ...
7 years, 7 months ago (2011-11-03 09:13:46 UTC) #13
pkx166h
This still needs work but I need some decisions err.. decided and some more input ...
7 years, 7 months ago (2011-11-04 23:10:43 UTC) #14
mike_apollinemike.com
On Nov 4, 2011, at 4:10 PM, pkx166h@gmail.com wrote: > This still needs work but ...
7 years, 7 months ago (2011-11-07 07:31:11 UTC) #15
dak
"mike@apollinemike.com" <mike@apollinemike.com> writes: > I guess because we are not indicating a grob i.e. > ...
7 years, 7 months ago (2011-11-07 12:20:54 UTC) #16
pkx166h
7 years, 7 months ago (2011-11-19 14:30:50 UTC) #17
Having a rethink on this section, after Graham's comments.

Currently trying to simplify some of the examples and explanations. Also need to
include the \markup function \auto-footnote as well. I'll close the Reitveld and
open a new one when I'm done (hopefully in the next day or so).

James
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b