Issue 5315048: Added a function to retrieve all aliases for a user

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5315048: Added a function to retrieve all aliases for a user

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by gunjansharma

Modified:
12 years, 6 months ago

Reviewers:
Vic Fryzel, Claudio Cherubino, jcgregorio

CC:
gdata-python-client-library-contributors_googlegroups.com

Visibility:
Public.

Patch Set 2 : Changed the line with more than 80 chars #

Total comments: 1

Patch Set 3 : indentation error removed #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/gdata/apps/multidomain/client.py	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Claudio Cherubino

LGTM as soon as you address that single comment http://codereview.appspot.com/5315048/diff/3001/src/gdata/apps/multidomain/client.py File src/gdata/apps/multidomain/client.py (right): http://codereview.appspot.com/5315048/diff/3001/src/gdata/apps/multidomain/client.py#newcode314 src/gdata/apps/multidomain/client.py:314: ...

12 years, 6 months ago (2011-10-20 16:50:19 UTC) #3

Claudio Cherubino

12 years, 6 months ago (2011-10-21 17:14:13 UTC) #5

On 2011/10/21 17:02:16, gunjansharma wrote:

LGTM

Expand All Messages | Collapse All Messages