Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2934)

Issue 5314063: Fix issues with initializers for let/const. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by arv
Modified:
12 years, 6 months ago
CC:
traceur-compiler-reviews_google.com
Base URL:
https://traceur-compiler.googlecode.com/svn/trunk
Visibility:
Public.

Description

Fix issues with initializers for let/const. BUG=http://code.google.com/p/traceur-compiler/issues/detail?id=29 TEST=test/feature/Classes/Error_ConstMissingInitializer.js test/feature/Scope/Error_ConstMissingInitializer.js test/feature/Scope/Error_ForInWithInitializerConst.js test/feature/Scope/Error_ForInWithInitializerLet.js test/feature/Scope/Error_ForOfWithInitializerConst.js test/feature/Scope/Error_ForOfWithInitializerLet.js test/feature/Scope/Error_ForOfWithInitializerVar.js test/feature/Scope/Error_ForWithoutInitializerConst.js test/feature/Scope/ForInWithInitializerVar.js test/feature/Scope/LetNoInitializer.js test/feature/Scope/LetNoInitializerGlobal.js Committed: http://code.google.com/p/traceur-compiler/source/detail?r=343

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix long lines and add one more test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -10 lines) Patch
M src/syntax/Parser.js View 1 4 chunks +28 lines, -10 lines 0 comments Download
A test/feature/Classes/Error_ConstMissingInitializer.js View 1 chunk +5 lines, -0 lines 0 comments Download
A test/feature/Scope/Error_ConstMissingInitializer.js View 1 chunk +3 lines, -0 lines 0 comments Download
A test/feature/Scope/Error_ForInWithInitializerConst.js View 1 chunk +4 lines, -0 lines 0 comments Download
A test/feature/Scope/Error_ForInWithInitializerLet.js View 1 chunk +4 lines, -0 lines 0 comments Download
A test/feature/Scope/Error_ForOfWithInitializerConst.js View 1 chunk +8 lines, -0 lines 0 comments Download
A test/feature/Scope/Error_ForOfWithInitializerLet.js View 1 chunk +8 lines, -0 lines 0 comments Download
A test/feature/Scope/Error_ForOfWithInitializerVar.js View 1 chunk +8 lines, -0 lines 0 comments Download
A test/feature/Scope/Error_ForWithoutInitializerConst.js View 1 chunk +6 lines, -0 lines 0 comments Download
A test/feature/Scope/ForInWithInitializerVar.js View 1 chunk +7 lines, -0 lines 0 comments Download
A test/feature/Scope/LetNoInitializer.js View 1 chunk +8 lines, -0 lines 0 comments Download
A test/feature/Scope/LetNoInitializerGlobal.js View 1 1 chunk +4 lines, -0 lines 0 comments Download
M test/feature/feature_test.html View 1 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3
arv
https://codereview.appspot.com/5314063/diff/1/src/syntax/Parser.js File src/syntax/Parser.js (left): https://codereview.appspot.com/5314063/diff/1/src/syntax/Parser.js#oldcode1530 src/syntax/Parser.js:1530: this.reportError_('const variables must have an initializer'); This now gets ...
12 years, 6 months ago (2011-10-28 05:49:17 UTC) #1
cburrows
LGTM
12 years, 6 months ago (2011-10-31 06:53:36 UTC) #2
slightlylate
12 years, 6 months ago (2011-10-31 15:20:34 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b