Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1863)

Issue 5308077: code review 5308077: weekly.2011-11-02 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by adg
Modified:
9 years, 4 months ago
Reviewers:
CC:
golang-dev, bradfitz, rsc
Visibility:
Public.

Description

weekly.2011-11-02

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r 085f3ad02135 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M .hgtags View 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/weekly.html View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 4 months ago (2011-11-02 02:00:44 UTC) #1
bradfitz
http://codereview.appspot.com/5308077/diff/1/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5308077/diff/1/doc/devel/weekly.html#newcode27 doc/devel/weekly.html:27: Error to String. Package fmt's Print formats both Stringers ...
9 years, 4 months ago (2011-11-02 02:19:53 UTC) #2
rsc
ouch, thanks (my bad) On Tue, Nov 1, 2011 at 22:19, <bradfitz@golang.org> wrote: > both ...
9 years, 4 months ago (2011-11-02 02:21:48 UTC) #3
adg
Wow, I missed it too. Thanks. On 2 November 2011 11:19, <bradfitz@golang.org> wrote: > > ...
9 years, 4 months ago (2011-11-02 02:23:31 UTC) #4
rsc
LGTM
9 years, 4 months ago (2011-11-02 02:25:51 UTC) #5
adg
9 years, 4 months ago (2011-11-02 03:00:21 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=780c85032b17 ***

weekly.2011-11-02

R=golang-dev, bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/5308077
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b