Issue 5308077: code review 5308077: weekly.2011-11-02

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5308077: code review 5308077: weekly.2011-11-02 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by adg

Modified:
12 years, 5 months ago

Reviewers:

CC:
golang-dev, bradfitz, rsc

Visibility:
Public.

Patch Set 2 : diff -r 085f3ad02135 https://go.googlecode.com/hg/ #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -1 line)			Patch
	M	.hgtags	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	doc/devel/weekly.html	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 5 months ago (2011-11-02 02:00:44 UTC) #1

bradfitz

http://codereview.appspot.com/5308077/diff/1/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5308077/diff/1/doc/devel/weekly.html#newcode27 doc/devel/weekly.html:27: Error to String. Package fmt's Print formats both Stringers ...

12 years, 5 months ago (2011-11-02 02:19:53 UTC) #2

rsc

ouch, thanks (my bad) On Tue, Nov 1, 2011 at 22:19, <bradfitz@golang.org> wrote: > both ...

12 years, 5 months ago (2011-11-02 02:21:48 UTC) #3

adg

Wow, I missed it too. Thanks. On 2 November 2011 11:19, <bradfitz@golang.org> wrote: > > ...

12 years, 5 months ago (2011-11-02 02:23:31 UTC) #4

adg

12 years, 5 months ago (2011-11-02 03:00:21 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=780c85032b17 ***

weekly.2011-11-02

R=golang-dev, bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/5308077

Expand All Messages | Collapse All Messages