Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(475)

Issue 5307080: code review 5307080: builtin: document built-in error type (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by adg
Modified:
3 months, 2 weeks ago
Reviewers:
rsc, r, r2, illia1991nabatov, bradfitz, rog
CC:
golang-dev, dsymonds, r
Visibility:
Public.

Description

builtin: document built-in error type

Patch Set 1 #

Patch Set 2 : diff -r 3c4a4158c858 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3c4a4158c858 https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 4 : diff -r 3c4a4158c858 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 3c4a4158c858 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 6273f8345164 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/pkg/builtin/builtin.go View 1 2 3 4 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 14
adg
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 4 months ago (2011-11-02 04:42:34 UTC) #1
dsymonds
This does not fit the remit of this pseudo-package, which is for builtin functions (the ...
9 years, 4 months ago (2011-11-02 04:53:37 UTC) #2
adg
I think it warrants inclusion. Happy to hear other opinions.
9 years, 4 months ago (2011-11-02 04:57:25 UTC) #3
r
http://codereview.appspot.com/5307080/diff/4/src/pkg/builtin/builtin.go File src/pkg/builtin/builtin.go (right): http://codereview.appspot.com/5307080/diff/4/src/pkg/builtin/builtin.go#newcode6 src/pkg/builtin/builtin.go:6: Package builtin provides documentation for Go's built-in functions. functions ...
9 years, 4 months ago (2011-11-02 05:09:23 UTC) #4
adg
PTAL On 2 November 2011 14:09, <r@golang.org> wrote: > Go's built-in functions. > functions and ...
9 years, 4 months ago (2011-11-02 05:19:37 UTC) #5
r
LGTM
9 years, 4 months ago (2011-11-02 05:55:18 UTC) #6
adg
*** Submitted as http://code.google.com/p/go/source/detail?r=c0b08c584190 *** builtin: document built-in error type R=golang-dev, dsymonds, r CC=golang-dev http://codereview.appspot.com/5307080
9 years, 4 months ago (2011-11-02 06:03:42 UTC) #7
rsc
what about int, uint, byte, rune, uintptr?
9 years, 4 months ago (2011-11-02 12:44:04 UTC) #8
rog
i think they could go in, with appropriate remarks on their size guarantees or constraints. ...
9 years, 4 months ago (2011-11-02 13:27:23 UTC) #9
adg
I think if we want to document the other builtin types we should update godoc ...
9 years, 4 months ago (2011-11-02 22:58:32 UTC) #10
bradfitz
OTOH, type int is an int... On Wed, Nov 2, 2011 at 3:58 PM, Andrew ...
9 years, 4 months ago (2011-11-02 23:00:11 UTC) #11
r2
On Nov 2, 2011, at 4:00 PM, Brad Fitzpatrick wrote: > OTOH, type int is ...
9 years, 4 months ago (2011-11-02 23:04:51 UTC) #12
bradfitz
On Wed, Nov 2, 2011 at 4:04 PM, Rob 'Commander' Pike <r@google.com> wrote: > > ...
9 years, 4 months ago (2011-11-02 23:07:32 UTC) #13
illia1991nabatov
5 months ago (2020-10-08 12:48:10 UTC) #14
Message was sent while issue was closed.
On 2011/11/02 23:00:11, bradfitz wrote:
> OTOH, type int is an int...
> 
> On Wed, Nov 2, 2011 at 3:58 PM, Andrew Gerrand <mailto:adg@golang.org> wrote:
> 
> > I think if we want to document the other builtin types we should update
> > godoc to present them differently.
> >
> > type int int // this is confusing
> >
> >
> > On Thursday, 3 November 2011, roger peppe <mailto:rogpeppe@gmail.com> wrote:
> > > i think they could go in, with appropriate remarks on
> > > their size guarantees or constraints.
> > >
> > > how to phrase the type declaration, though?
> > >
> > > type int int
> > >
> > > perhaps.
> > >
> > > On 2 November 2011 08:44, Russ Cox <mailto:rsc@golang.org> wrote:
> > >> what about int, uint, byte, rune, uintptr?
> > >
> >
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b