|
|
Created:
12 years, 11 months ago by adg Modified:
2 years, 3 months ago CC:
golang-dev, dsymonds, r Visibility:
Public. |
Descriptionbuiltin: document built-in error type
Patch Set 1 #Patch Set 2 : diff -r 3c4a4158c858 https://go.googlecode.com/hg/ #Patch Set 3 : diff -r 3c4a4158c858 https://go.googlecode.com/hg/ #
Total comments: 3
Patch Set 4 : diff -r 3c4a4158c858 https://go.googlecode.com/hg/ #Patch Set 5 : diff -r 3c4a4158c858 https://go.googlecode.com/hg/ #Patch Set 6 : diff -r 6273f8345164 https://go.googlecode.com/hg/ #MessagesTotal messages: 16
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
Sign in to reply to this message.
This does not fit the remit of this pseudo-package, which is for builtin functions (the types at the top are exceptional). We don't document other builtin types here.
Sign in to reply to this message.
I think it warrants inclusion. Happy to hear other opinions.
Sign in to reply to this message.
http://codereview.appspot.com/5307080/diff/4/src/pkg/builtin/builtin.go File src/pkg/builtin/builtin.go (right): http://codereview.appspot.com/5307080/diff/4/src/pkg/builtin/builtin.go#newcode6 src/pkg/builtin/builtin.go:6: Package builtin provides documentation for Go's built-in functions. functions and facilities? http://codereview.appspot.com/5307080/diff/4/src/pkg/builtin/builtin.go#newcode7 src/pkg/builtin/builtin.go:7: The functions documented here are not actually in package builtin s/functions/items/ http://codereview.appspot.com/5307080/diff/4/src/pkg/builtin/builtin.go#newcode9 src/pkg/builtin/builtin.go:9: for the language's special functions. s/functions/identifiers.
Sign in to reply to this message.
PTAL On 2 November 2011 14:09, <r@golang.org> wrote: > Go's built-in functions. > functions and facilities? I went with "Go's predeclared identifiers." ?
Sign in to reply to this message.
*** Submitted as http://code.google.com/p/go/source/detail?r=c0b08c584190 *** builtin: document built-in error type R=golang-dev, dsymonds, r CC=golang-dev http://codereview.appspot.com/5307080
Sign in to reply to this message.
what about int, uint, byte, rune, uintptr?
Sign in to reply to this message.
i think they could go in, with appropriate remarks on their size guarantees or constraints. how to phrase the type declaration, though? type int int perhaps. On 2 November 2011 08:44, Russ Cox <rsc@golang.org> wrote: > what about int, uint, byte, rune, uintptr?
Sign in to reply to this message.
I think if we want to document the other builtin types we should update godoc to present them differently. type int int // this is confusing On Thursday, 3 November 2011, roger peppe <rogpeppe@gmail.com> wrote: > i think they could go in, with appropriate remarks on > their size guarantees or constraints. > > how to phrase the type declaration, though? > > type int int > > perhaps. > > On 2 November 2011 08:44, Russ Cox <rsc@golang.org> wrote: >> what about int, uint, byte, rune, uintptr? >
Sign in to reply to this message.
OTOH, type int is an int... On Wed, Nov 2, 2011 at 3:58 PM, Andrew Gerrand <adg@golang.org> wrote: > I think if we want to document the other builtin types we should update > godoc to present them differently. > > type int int // this is confusing > > > On Thursday, 3 November 2011, roger peppe <rogpeppe@gmail.com> wrote: > > i think they could go in, with appropriate remarks on > > their size guarantees or constraints. > > > > how to phrase the type declaration, though? > > > > type int int > > > > perhaps. > > > > On 2 November 2011 08:44, Russ Cox <rsc@golang.org> wrote: > >> what about int, uint, byte, rune, uintptr? > > >
Sign in to reply to this message.
On Nov 2, 2011, at 4:00 PM, Brad Fitzpatrick wrote: > OTOH, type int is an int... it certainly behaves like one. -rob
Sign in to reply to this message.
On Wed, Nov 2, 2011 at 4:04 PM, Rob 'Commander' Pike <r@google.com> wrote: > > On Nov 2, 2011, at 4:00 PM, Brad Fitzpatrick wrote: > > > OTOH, type int is an int... > > it certainly behaves like one. at least when it's not behaving like its other 4294967295 numbers.
Sign in to reply to this message.
Message was sent while issue was closed.
On 2011/11/02 23:00:11, bradfitz wrote: > OTOH, type int is an int... > > On Wed, Nov 2, 2011 at 3:58 PM, Andrew Gerrand <mailto:adg@golang.org> wrote: > > > I think if we want to document the other builtin types we should update > > godoc to present them differently. > > > > type int int // this is confusing > > > > > > On Thursday, 3 November 2011, roger peppe <mailto:rogpeppe@gmail.com> wrote: > > > i think they could go in, with appropriate remarks on > > > their size guarantees or constraints. > > > > > > how to phrase the type declaration, though? > > > > > > type int int > > > > > > perhaps. > > > > > > On 2 November 2011 08:44, Russ Cox <mailto:rsc@golang.org> wrote: > > >> what about int, uint, byte, rune, uintptr? > > > > >
Sign in to reply to this message.
Message was sent while issue was closed.
On 2011/11/02 05:55:18, r wrote: > LGTM https://cs.opensource.google/go/go/+/refs/tags/go1.18.3:src/builtin/builtin.go
Sign in to reply to this message.
នៅថ្ងៃទី សុក្រ 1 កក្កដា 2022, 3:00 PM <hackercombodia855@gmail.com> បានសរសេរថា៖ > On 2011/11/02 05:55:18, r wrote: > > LGTM > > > https://cs.opensource.google/go/go/+/refs/tags/go1.18.3:src/builtin/builtin.go > > https://codereview.appspot.com/5307080/ >
Sign in to reply to this message.
|