Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1732)

Issue 5306077: Uv tools

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by psy-fi
Modified:
7 years, 5 months ago
Reviewers:
dingto, sergey.vfx, brechtvl
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

Uv tools created during GSOC 2011. To see functionality included see: http://wiki.blender.org/index.php/User:Psy-Fi Stitch documentation may need some updating, but mostly correct for now check image/uv area header for instructions.

Patch Set 1 #

Patch Set 2 : some corrections for load functions left over from onion #

Patch Set 3 : Avoid hang in static island resolving when redoing operator stitch #

Total comments: 79

Patch Set 4 : A few remarks taken care of #

Total comments: 9

Patch Set 5 : patch with changes so far. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3660 lines, -316 lines) Patch
release/scripts/modules/bpy_extras/keyconfig_utils.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
release/scripts/startup/bl_ui/space_image.py View 1 2 3 4 5 chunks +85 lines, -3 lines 0 comments Download
release/scripts/startup/bl_ui/space_userpref.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
source/blender/blenkernel/BKE_mesh.h View 1 2 3 4 2 chunks +37 lines, -1 line 0 comments Download
source/blender/blenkernel/intern/paint.c View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
source/blender/blenkernel/intern/scene.c View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
source/blender/blenlib/BLI_math_vector.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
source/blender/blenlib/intern/math_vector_inline.c View 1 2 3 4 2 chunks +6 lines, -1 line 0 comments Download
source/blender/blenloader/intern/readfile.c View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
source/blender/blenloader/intern/writefile.c View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
source/blender/editors/include/ED_image.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
source/blender/editors/include/ED_mesh.h View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
source/blender/editors/include/ED_screen.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
source/blender/editors/include/ED_uvedit.h View 1 2 3 4 2 chunks +6 lines, -1 line 0 comments Download
source/blender/editors/include/ED_view3d.h View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
source/blender/editors/include/UI_resources.h View 1 2 3 4 1 chunk +9 lines, -1 line 0 comments Download
source/blender/editors/interface/resources.c View 1 2 3 4 3 chunks +40 lines, -0 lines 0 comments Download
source/blender/editors/mesh/editmesh_lib.c View 1 2 3 4 5 chunks +217 lines, -10 lines 0 comments Download
source/blender/editors/object/object_edit.c View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
source/blender/editors/screen/screen_ops.c View 1 2 3 4 2 chunks +23 lines, -0 lines 0 comments Download
source/blender/editors/sculpt_paint/CMakeLists.txt View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
source/blender/editors/sculpt_paint/SConscript View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
source/blender/editors/sculpt_paint/paint_image.c View 1 2 3 4 17 chunks +92 lines, -15 lines 0 comments Download
source/blender/editors/sculpt_paint/paint_intern.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
source/blender/editors/sculpt_paint/paint_ops.c View 1 2 3 4 4 chunks +50 lines, -0 lines 0 comments Download
source/blender/editors/sculpt_paint/sculpt_uv.c View 1 2 3 4 1 chunk +668 lines, -0 lines 0 comments Download
source/blender/editors/space_image/image_ops.c View 1 2 3 4 3 chunks +26 lines, -2 lines 0 comments Download
source/blender/editors/space_image/space_image.c View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
source/blender/editors/space_view3d/view3d_draw.c View 1 2 3 4 3 chunks +3 lines, -1 line 0 comments Download
source/blender/editors/uvedit/CMakeLists.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
source/blender/editors/uvedit/uvedit_draw.c View 1 2 3 4 7 chunks +101 lines, -11 lines 0 comments Download
source/blender/editors/uvedit/uvedit_intern.h View 1 2 3 4 2 chunks +42 lines, -1 line 0 comments Download
source/blender/editors/uvedit/uvedit_ops.c View 1 2 3 4 12 chunks +187 lines, -207 lines 0 comments Download
source/blender/editors/uvedit/uvedit_parametrizer.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
source/blender/editors/uvedit/uvedit_parametrizer.c View 1 2 3 4 5 chunks +11 lines, -1 line 0 comments Download
source/blender/editors/uvedit/uvedit_smart_stitch.c View 1 2 3 4 1 chunk +1433 lines, -0 lines 0 comments Download
source/blender/editors/uvedit/uvedit_unwrap_ops.c View 1 2 3 4 10 chunks +279 lines, -6 lines 0 comments Download
source/blender/gpu/intern/gpu_draw.c View 1 2 3 4 7 chunks +117 lines, -39 lines 0 comments Download
source/blender/imbuf/IMB_imbuf.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
source/blender/makesdna/DNA_scene_types.h View 1 2 3 4 8 chunks +29 lines, -2 lines 0 comments Download
source/blender/makesdna/DNA_userdef_types.h View 1 2 3 4 3 chunks +9 lines, -4 lines 0 comments Download
source/blender/makesrna/RNA_access.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
source/blender/makesrna/intern/rna_scene.c View 1 2 3 4 5 chunks +69 lines, -0 lines 0 comments Download
source/blender/makesrna/intern/rna_sculpt_paint.c View 1 2 3 4 2 chunks +12 lines, -0 lines 0 comments Download
source/blender/makesrna/intern/rna_userdef.c View 1 2 3 4 4 chunks +50 lines, -0 lines 0 comments Download
source/blender/windowmanager/intern/wm_keymap.c View 1 2 3 4 1 chunk +8 lines, -1 line 0 comments Download
source/blenderplayer/bad_level_call_stubs/stubs.c View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22
psy-fi
7 years, 8 months ago (2011-10-28 23:33:33 UTC) #1
psy-fi
some corrections for load functions left over from onion
7 years, 7 months ago (2011-10-31 13:54:10 UTC) #2
psy-fi
Avoid hang in static island resolving when redoing operator stitch
7 years, 7 months ago (2011-11-01 15:14:17 UTC) #3
dingto
Some quick going over code style in rna/dna and UI scripts. Overall, looks good to ...
7 years, 7 months ago (2011-11-02 15:09:28 UTC) #4
brechtvl
Some initial comments from quick read over the code. http://codereview.appspot.com/5306077/diff/7005/release/scripts/startup/bl_ui/space_image.py File release/scripts/startup/bl_ui/space_image.py (right): http://codereview.appspot.com/5306077/diff/7005/release/scripts/startup/bl_ui/space_image.py#newcode56 release/scripts/startup/bl_ui/space_image.py:56: ...
7 years, 6 months ago (2011-12-16 17:24:07 UTC) #5
sergey.vfx
Hi, Made first itteration of review. I don't think check of malloc() result is indeed ...
7 years, 6 months ago (2011-12-16 17:32:38 UTC) #6
brechtvl
Reviewed high bit depth texture part. http://codereview.appspot.com/5306077/diff/7005/source/blender/editors/uvedit/uvedit_draw.c File source/blender/editors/uvedit/uvedit_draw.c (right): http://codereview.appspot.com/5306077/diff/7005/source/blender/editors/uvedit/uvedit_draw.c#newcode931 source/blender/editors/uvedit/uvedit_draw.c:931: ToolSettings *toolsettings = ...
7 years, 6 months ago (2011-12-17 13:59:57 UTC) #7
psy-fi
A few remarks taken care of
7 years, 6 months ago (2011-12-21 17:55:49 UTC) #8
psy-fi
A few comments for the remarks http://codereview.appspot.com/5306077/diff/7005/release/scripts/startup/bl_ui/space_image.py File release/scripts/startup/bl_ui/space_image.py (right): http://codereview.appspot.com/5306077/diff/7005/release/scripts/startup/bl_ui/space_image.py#newcode56 release/scripts/startup/bl_ui/space_image.py:56: layout.prop(uv, "show_other_objects") because ...
7 years, 6 months ago (2011-12-21 17:56:20 UTC) #9
brechtvl
On 2011/12/21 17:56:20, psy-fi wrote: > http://codereview.appspot.com/5306077/diff/7005/release/scripts/startup/bl_ui/space_userpref.py > File release/scripts/startup/bl_ui/space_userpref.py (right): > > http://codereview.appspot.com/5306077/diff/7005/release/scripts/startup/bl_ui/space_userpref.py#newcode426 > ...
7 years, 6 months ago (2011-12-22 14:48:19 UTC) #10
brechtvl
Testing the UV unwrap subsurf function, I can't really see enabling subsurf giving better results ...
7 years, 6 months ago (2011-12-22 14:58:07 UTC) #11
psy-fi
Hi brecht, it helps on subdivided meshes on areas with high curvature. I have attached ...
7 years, 6 months ago (2011-12-22 15:38:58 UTC) #12
psy-fi
Gaah! I meant -without- you get stretching. I know it's not a big effect. And ...
7 years, 6 months ago (2011-12-22 15:52:35 UTC) #13
psy-fi
Hi brecht, another thing, just remembered that I need to actually keep the derivedMesh because ...
7 years, 6 months ago (2011-12-22 15:57:34 UTC) #14
brechtvl
Tested the UV tools. I'm not convinced UV sculpt is a feature we should have ...
7 years, 6 months ago (2011-12-22 16:39:36 UTC) #15
brechtvl
http://codereview.appspot.com/5306077/diff/34002/source/blender/editors/include/ED_uvedit.h File source/blender/editors/include/ED_uvedit.h (right): http://codereview.appspot.com/5306077/diff/34002/source/blender/editors/include/ED_uvedit.h#newcode90 source/blender/editors/include/ED_uvedit.h:90: /* uvedit_island_manager.c */ There is no uvedit_island_manager.c. http://codereview.appspot.com/5306077/diff/34002/source/blender/makesdna/DNA_scene_types.h File ...
7 years, 6 months ago (2011-12-22 16:54:14 UTC) #16
brechtvl
http://codereview.appspot.com/5306077/diff/34002/source/blender/editors/sculpt_paint/paint_image.c File source/blender/editors/sculpt_paint/paint_image.c (right): http://codereview.appspot.com/5306077/diff/34002/source/blender/editors/sculpt_paint/paint_image.c#newcode5820 source/blender/editors/sculpt_paint/paint_image.c:5820: What is the use case for these tools, it ...
7 years, 6 months ago (2011-12-22 17:02:56 UTC) #17
psy-fi
Most remarks taken care of, yet another patch coming soon. http://codereview.appspot.com/5306077/diff/7005/release/scripts/startup/bl_ui/space_image.py File release/scripts/startup/bl_ui/space_image.py (right): http://codereview.appspot.com/5306077/diff/7005/release/scripts/startup/bl_ui/space_image.py#newcode294 ...
7 years, 5 months ago (2012-01-04 18:22:34 UTC) #18
psy-fi
patch coming in a few minutes, stitch needs some more work to behave better on ...
7 years, 5 months ago (2012-01-05 23:55:27 UTC) #19
psy-fi
patch with changes so far.
7 years, 5 months ago (2012-01-06 00:04:50 UTC) #20
brechtvl
Reviewed latest version of branch now, and committed some simple tweaks and fixes, since the ...
7 years, 5 months ago (2012-01-10 21:40:37 UTC) #21
psy-fi
7 years, 5 months ago (2012-01-10 22:07:06 UTC) #22
Hi Brecht, excellent, thanks a lot for the help! What about grab brushes for uv
sculpt? Also, I was thinking to also bring back the edge mode on stitching. The
rationale is that edges have a 1-1 correspondence between islands while uv
vertices can sometimes be selected across islands you may not need.

About HC/Laplacian, they produce a different result, though I can't seem to
think a proper name for them...Laplacian produces more uniform relaxation while
HC produces more concentrated and tense result at the edges of the island. If
only one is to be kept I would keep the Laplacian. I used both the algorithms
that Raul had made to see how they behaved. I don't think someone will have a
reason to use HC though.

I will look for any leftovers in the comments that need addressing(shouldn't be
a lot).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b