Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13839)

Issue 5304054: LTE RRC Extension

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by pankaj
Modified:
12 years, 6 months ago
CC:
ns-developers_isi.edu
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1979 lines, -34 lines) Patch
M src/lte/helper/lte-helper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/lte/model/enb-net-device.h View 3 chunks +10 lines, -0 lines 0 comments Download
M src/lte/model/enb-net-device.cc View 4 chunks +19 lines, -2 lines 0 comments Download
A src/lte/model/enb-rrc-entity.h View 1 chunk +142 lines, -0 lines 0 comments Download
A src/lte/model/enb-rrc-entity.cc View 1 chunk +245 lines, -0 lines 0 comments Download
M src/lte/model/ideal-control-messages.h View 1 chunk +14 lines, -2 lines 0 comments Download
M src/lte/model/lte-net-device.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/lte/model/lte-net-device.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M src/lte/model/rrc-entity.h View 2 chunks +24 lines, -0 lines 0 comments Download
A src/lte/model/rrc-ideal-control-messages.h View 1 chunk +530 lines, -0 lines 0 comments Download
A src/lte/model/rrc-ideal-control-messages.cc View 1 chunk +233 lines, -0 lines 0 comments Download
M src/lte/model/ue-net-device.h View 3 chunks +10 lines, -1 line 0 comments Download
M src/lte/model/ue-net-device.cc View 4 chunks +21 lines, -2 lines 0 comments Download
M src/lte/model/ue-record.h View 3 chunks +36 lines, -1 line 0 comments Download
A src/lte/model/ue-rrc-entity.h View 1 chunk +194 lines, -0 lines 0 comments Download
A src/lte/model/ue-rrc-entity.cc View 1 chunk +259 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-rrc-messages.cc View 1 chunk +229 lines, -0 lines 0 comments Download
M src/lte/wscript View 3 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 1
pankaj
12 years, 6 months ago (2011-10-24 06:16:16 UTC) #1
Hi All, 

I have enhanced the RRC state machine as per the review. Earlier we are directly
changing the states once the message is received to the eNodeB.

Now after the exchange of setup and setup complete messages we are updating the
states.

Please find the review code 

http://codereview.appspot.com/5304054/

Regarding merging issues,

The questions raised by Nicola are very valid and need to be defend. 

When we started we had few of the points in mind, But due to time constraints we
tried to complete the basic messages that rrc has to perform. 

As the first step to the project. 
1. Incorporation of RRC messages into ns-3 LTE. Which we have successfully
achieved.

One can always extend these to make a simulation scenario. 
1. during call with the data packets control packets also flows, which effect
the performance. 

I propose to include following things for the future releases which will enhance
the capabilities of ns-3 lte module. 

The broad issue which need to incorporate 

1. Linking of RRC messages to the RLC entity.
2. Rather using idelchannels use SRBs which need to be written.


I seek further advice and refinement as to how it can be achieved in the best
possible way considering the future releases and new architecture of ns-3 lte
module.

Regards
Pankaj
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b