Issue 52920043: code review 52920043: go.tools/oracle: disable broken test (fix build)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 52920043: code review 52920043: go.tools/oracle: disable broken test (fix build) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by gri

Modified:
11 years, 5 months ago

Reviewers:
adonovan

CC:
adonovan, golang-codereviews

Visibility:
Public.

Description

go.tools/oracle: disable broken test (fix build)

Patch Set 2 : diff -r 6b74f466ef7a https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 6b74f466ef7a https://code.google.com/p/go.tools #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	oracle/oracle_test.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello adonovan, adonovan@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

11 years, 5 months ago (2014-01-16 00:25:38 UTC) #1

gri

*** Submitted as https://code.google.com/p/go/source/detail?r=3b23bd5642b6&repo=tools *** go.tools/oracle: disable broken test (fix build) R=adonovan TBR=adonovan CC=golang-codereviews https://codereview.appspot.com/52920043

11 years, 5 months ago (2014-01-16 00:25:41 UTC) #2

adonovan

11 years, 5 months ago (2014-01-16 01:47:30 UTC) #3

LGTM

Proper fix pending.


On 15 January 2014 19:25, <gri@golang.org> wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=3b23bd5642b6&repo=tools ***
>
>
> go.tools/oracle: disable broken test (fix build)
>
> R=adonovan
> TBR=adonovan
> CC=golang-codereviews
> https://codereview.appspot.com/52920043
>
>
> https://codereview.appspot.com/52920043/
>

Expand All Messages | Collapse All Messages