Eliminate MachineConfig client API

Eliminate MachineConfig client API

The MachineConfig API has been superseded by
ProvisioningScript for manual provisioning.
Manual provisioning has been updated to use
ProvisioningScript, and MachineConfig removed
as it was added in the 1.17.0 release, and so
is unsupported.

Accordingly, statecmd.MachineConfig has been
combined with statecmd.FinishMachineConfig,
and it deals directly with the environs/config
MachineConfig struct.

Fixes #1270043

https://code.launchpad.net/~axwalk/juju-core/lp1270043-drop-machineconfig-api/+merge/202592

(do not edit description out of merge proposal)

[axw, 2014-01-22 03:46:56]

Please take a look.

[gz, 2014-01-23 13:43:37]

LGTM, please land for 1.17.1 release. :)

https://codereview.appspot.com/52900045/diff/1/cloudinit/sshinit/configure.go
File cloudinit/sshinit/configure.go (right):

https://codereview.appspot.com/52900045/diff/1/cloudinit/sshinit/configure.go...
cloudinit/sshinit/configure.go:45: // Run connects to the specified host over
SSH,
*RunConfigureScript

https://codereview.appspot.com/52900045/diff/1/cloudinit/sshinit/configure.go...
cloudinit/sshinit/configure.go:49: logger.Infof("Provisioning machine agent on
%s", params.Host)
Why move this log line later? Having it right next to the debug one below is
just a little silly, and it seemed fine where it was (logging even if
ConfigureScript errored).

https://codereview.appspot.com/52900045/diff/1/environs/manual/provisioner.go
File environs/manual/provisioner.go (right):

https://codereview.appspot.com/52900045/diff/1/environs/manual/provisioner.go...
environs/manual/provisioner.go:293: func provisionMachineAgent(host string, mcfg
*cloudinit.MachineConfig, stderr io.Writer) error {
Pre-exisiting nit, naming the writer 'stderr' when it can be any writer is
confusing.

https://codereview.appspot.com/52900045/diff/1/state/statecmd/machineconfig_t...
File state/statecmd/machineconfig_test.go (right):

https://codereview.appspot.com/52900045/diff/1/state/statecmd/machineconfig_t...
state/statecmd/machineconfig_test.go:57: c.Assert(machineConfig.APIInfo.Addrs,
gc.DeepEquals, apiInfo.Addrs)
These two DeepEquals Asserts could be Check instead?

[axw, 2014-01-23 23:20:11]

Please take a look.

https://codereview.appspot.com/52900045/diff/1/cloudinit/sshinit/configure.go
File cloudinit/sshinit/configure.go (right):

https://codereview.appspot.com/52900045/diff/1/cloudinit/sshinit/configure.go...
cloudinit/sshinit/configure.go:45: // Run connects to the specified host over
SSH,
On 2014/01/23 13:43:37, gz wrote:
> *RunConfigureScript

Done.

https://codereview.appspot.com/52900045/diff/1/cloudinit/sshinit/configure.go...
cloudinit/sshinit/configure.go:49: logger.Infof("Provisioning machine agent on
%s", params.Host)
On 2014/01/23 13:43:37, gz wrote:
> Why move this log line later? Having it right next to the debug one below is
> just a little silly, and it seemed fine where it was (logging even if
> ConfigureScript errored).

I moved it because not everything uses Configure, and DEBUG may not be enabled.
Manual provisioning uses ConfigureScript and RunConfigureScript separately. It
doesn't really matter; I will move the log line back.

https://codereview.appspot.com/52900045/diff/1/environs/manual/provisioner.go
File environs/manual/provisioner.go (right):

https://codereview.appspot.com/52900045/diff/1/environs/manual/provisioner.go...
environs/manual/provisioner.go:293: func provisionMachineAgent(host string, mcfg
*cloudinit.MachineConfig, stderr io.Writer) error {
On 2014/01/23 13:43:37, gz wrote:
> Pre-exisiting nit, naming the writer 'stderr' when it can be any writer is
> confusing.

Yeah, good call. I've renamed to progressWriter. Also renamed
sshinit.ConfigureParams.Stderr to ProgressWriter.

https://codereview.appspot.com/52900045/diff/1/state/statecmd/machineconfig_t...
File state/statecmd/machineconfig_test.go (right):

https://codereview.appspot.com/52900045/diff/1/state/statecmd/machineconfig_t...
state/statecmd/machineconfig_test.go:57: c.Assert(machineConfig.APIInfo.Addrs,
gc.DeepEquals, apiInfo.Addrs)
On 2014/01/23 13:43:37, gz wrote:
> These two DeepEquals Asserts could be Check instead?

Done.