Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(304)

Issue 5283049: MovieCache implementation

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by nazgul
Modified:
7 years, 8 months ago
Reviewers:
bf-codereview, brechtvl
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

Implementation of cache for general movie-related areas such as sequencer and clip editor (in the future) Some changes in limiter were necessary: - Limiter counted mapped memory twice when was checking how many memory is used. - It was using "global" memory usage not memory usage by cached elements. It will cause big problems when there's large mesh or plenty of undo steps are in memory nothing would be cached in sequencer. - To solve this problem introduced "callback" to measure cached element size. It could be not very accurate in general, but it works well for image buffers. And if this callback isn't set old-school memory usage check would be used. - The whole cache used to get freed when memory limit exceeded, now it'll drop only as much elements as necessary to reduce memory usage. Seqcache is switched to use this new cache code.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated patch set with most of issues fixed. IMB_cache_limiter_* would be removed separately. #

Patch Set 3 : Most recent patchset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+521 lines, -148 lines) Patch
intern/memutil/MEM_CacheLimiter.h View 1 3 chunks +35 lines, -3 lines 0 comments Download
intern/memutil/MEM_CacheLimiterC-Api.h View 1 2 chunks +5 lines, -1 line 0 comments Download
intern/memutil/intern/MEM_CacheLimiterC-Api.cpp View 1 2 chunks +6 lines, -4 lines 0 comments Download
source/blender/blenkernel/BKE_sequencer.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
source/blender/blenkernel/intern/blender.c View 1 2 chunks +2 lines, -0 lines 0 comments Download
source/blender/blenkernel/intern/seqcache.c View 1 6 chunks +31 lines, -137 lines 0 comments Download
source/blender/imbuf/CMakeLists.txt View 1 2 chunks +2 lines, -0 lines 0 comments Download
source/blender/imbuf/IMB_moviecache.h View 1 1 chunk +58 lines, -0 lines 0 comments Download
source/blender/imbuf/intern/allocimbuf.c View 1 1 chunk +1 line, -1 line 0 comments Download
source/blender/imbuf/intern/moviecache.c View 1 2 1 chunk +381 lines, -0 lines 0 comments Download

Messages

Total messages: 6
nazgul
7 years, 8 months ago (2011-10-15 16:43:32 UTC) #1
brechtvl
There's something wrong with the new files, they don't diff correctly and inline comments don't ...
7 years, 8 months ago (2011-10-15 17:55:32 UTC) #2
nazgul
Updated patch set with most of issues fixed. IMB_cache_limiter_* would be removed separately.
7 years, 8 months ago (2011-10-15 18:23:30 UTC) #3
nazgul
On 2011/10/15 17:55:32, brechtvl wrote: > There's something wrong with the new files, they don't ...
7 years, 8 months ago (2011-10-15 18:29:11 UTC) #4
nazgul
Most recent patchset
7 years, 8 months ago (2011-10-15 18:29:37 UTC) #5
brechtvl
7 years, 8 months ago (2011-10-15 18:41:31 UTC) #6
LGTM :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b