Change juju-gui-source to be git-enabled.

Change juju-gui-source to be git-enabled.

- Allow pulling from various repo urls
- Support checking out a branch name
- Support checkout out a direct sha
- Remove support for the trunk releases.

The list of what you can check out is simplified a bit. You can easily use the
git access, url, or a local file in the releases directory to enable loading
the gui with any combination of code you would like to use.

Drive by removing some left over bits of the PyJuju branch previously.

QA:

  juju boostrap
  make deploy
  # make sure the gui is running off the latest release. You can check the
  # local equivelent of https://jujucharms.com/juju-ui/version.js

Run the follow config changes and after each make sure that the version is
correct for what you've requested. You can get the sha values from looking in
Github.

https://github.com/juju/juju-gui/commits/develop

  # The develop support
  juju set juju-gui juju-gui-source="develop"
  # Supports the HEAD of a branch specified.
  juju set juju-gui juju-gui-source="https://github.com/juju/juju-gui.git network-prototype"
  # Supports an older commit in the main develop line.
  juju set juju-gui juju-gui-source="https://github.com/juju/juju-gui.git @c7ddd186"

https://code.launchpad.net/~rharding/charms/precise/juju-gui/git-ify/+merge/201442

(do not edit description out of merge proposal)

[rharding, 2014-01-16 14:45:47]

Please take a look.

[rharding, 2014-01-16 14:57:35]

Added reviewer comments

https://codereview.appspot.com/52790043/diff/60001/README.md
File README.md (left):

https://codereview.appspot.com/52790043/diff/60001/README.md#oldcode127
README.md:127: 3. Retry as described in the step 3 above (`juju resolved --retry
juju-gui/0`).
missed pyjuju cleanup.

https://codereview.appspot.com/52790043/diff/60001/README.md
File README.md (right):

https://codereview.appspot.com/52790043/diff/60001/README.md#newcode92
README.md:92: to build the source used by the charm.
this is just to reduce the duplication of what's supported. It generalizes it a
bit to read nicer.

https://codereview.appspot.com/52790043/diff/60001/config.yaml
File config.yaml (left):

https://codereview.appspot.com/52790043/diff/60001/config.yaml#oldcode24
config.yaml:24: - 'trunk': The latest release from the "trunk" series will be
deployed.
this was proven to not be used and there's so many other ways to load a specific
release now it's deemed redundant.

https://codereview.appspot.com/52790043/diff/60001/config.yaml#oldcode39
config.yaml:39: - a "url:" prefixed url: The release found at the given URL
file:// is gone for the same reason. You can stick that file at a url, you can
put it in the releases folder, you can just point at the branch for that file.

https://codereview.appspot.com/52790043/diff/60001/hooks/backend.py
File hooks/backend.py (right):

https://codereview.appspot.com/52790043/diff/60001/hooks/backend.py#newcode94
hooks/backend.py:94: if origin in ('branch', 'develop'):
develop is just a shortcut for the branch so it's moved up here.

https://codereview.appspot.com/52790043/diff/60001/hooks/backend.py#newcode112
hooks/backend.py:112: log('Using source {}: {}'.format(branch_url, revision))
added some logging helpers to make sure things were doing the right thing in QA.

https://codereview.appspot.com/52790043/diff/60001/hooks/install
File hooks/install (right):

https://codereview.appspot.com/52790043/diff/60001/hooks/install#newcode32
hooks/install:32: 'libapt-pkg-dev', 'python-apt', 'python-launchpadlib',
'python-tempita',
I hit this dep on trusty to build.

https://codereview.appspot.com/52790043/diff/60001/hooks/utils.py
File hooks/utils.py (right):

https://codereview.appspot.com/52790043/diff/60001/hooks/utils.py#newcode124
hooks/utils.py:124: git_checkout = command('git', 'clone', '--depth', '1')
this is the equivelent shallow clone. Note, to do a revision checkout we 'undo'
this later on.

https://codereview.appspot.com/52790043/diff/60001/hooks/utils.py#newcode276
hooks/utils.py:276: log('Source is defaulting to stable release.')
since this is a 'all else fails' log it to note it got hit.

https://codereview.appspot.com/52790043/diff/60001/hooks/utils.py#newcode568
hooks/utils.py:568: cmd_log(git_checkout(*checkout_args))
to do anything else we have to have a checkout. So we always checkout the
develop branch and then move on from there if a different branch or commit was
specified.

https://codereview.appspot.com/52790043/diff/60001/hooks/utils.py#newcode572
hooks/utils.py:572: git_dir = juju_gui_source_dir + "/.git"
our cwd isn't the source dir so we have to prefix the git commands with
--git-dir and --work-tree extra arguments to work on a git clone that's
elsewhere on the filesystem.

https://codereview.appspot.com/52790043/diff/60001/hooks/utils.py#newcode599
hooks/utils.py:599: run('make', '-C', juju_gui_source_dir, 'distfile',
'BRANCH_IS_GOOD=true',
this is the way to force generating a build from the updated Makefile release
process.

https://codereview.appspot.com/52790043/diff/60001/server/guiserver/auth.py
File server/guiserver/auth.py (right):

https://codereview.appspot.com/52790043/diff/60001/server/guiserver/auth.py#n...
server/guiserver/auth.py:23: - Authentication backends (GoBackend): the primary
more missed PyJuju cleanup.

https://codereview.appspot.com/52790043/diff/60001/tests/test_utils.py
File tests/test_utils.py (right):

https://codereview.appspot.com/52790043/diff/60001/tests/test_utils.py#newcod...
tests/test_utils.py:660: def test_stable_release(self, mock_log):
since we added a log statement have to patch it for this test case.

[rharding, 2014-01-16 18:03:27]

Please take a look.

[bac, 2014-01-16 19:00:53]

LGTM mit changes.
QA-A-OK

https://codereview.appspot.com/52790043/diff/60001/config.yaml
File config.yaml (right):

https://codereview.appspot.com/52790043/diff/60001/config.yaml#newcode3
config.yaml:3: # Copyright (C) 2012-2013 Canonical Ltd.
update for all files you touch.</pita>

https://codereview.appspot.com/52790043/diff/60001/hooks/install
File hooks/install (right):

https://codereview.appspot.com/52790043/diff/60001/hooks/install#newcode32
hooks/install:32: 'libapt-pkg-dev', 'python-apt', 'python-launchpadlib',
'python-tempita',
thanks for being out front.  i should upgrade to trusty soon.

https://codereview.appspot.com/52790043/diff/60001/hooks/utils.py
File hooks/utils.py (right):

https://codereview.appspot.com/52790043/diff/60001/hooks/utils.py#newcode123
hooks/utils.py:123: # Bazaar checkout command.
s/Bazaar c/C/

https://codereview.appspot.com/52790043/diff/60001/hooks/utils.py#newcode124
hooks/utils.py:124: git_checkout = command('git', 'clone', '--depth', '1')
I'd promote this review comment to a code comment.  Would be useful.

https://codereview.appspot.com/52790043/diff/60001/tests/test_utils.py
File tests/test_utils.py (right):

https://codereview.appspot.com/52790043/diff/60001/tests/test_utils.py#newcod...
tests/test_utils.py:660: def test_stable_release(self, mock_log):
If you aren't going to use the mock, and there may be more, I find using *args
to be appropriate.

https://codereview.appspot.com/52790043/diff/60001/tests/test_utils.py#newcod...
tests/test_utils.py:672: # A Bazaar branch is correctly parsed when including
revision.
s/Bazaar/git/

You may want to grep the whole tree for Bazaar and bzr.

[rharding, 2014-01-16 19:25:27]

Thanks for the review. Updated and re-running one final full functional test run
before landing.