Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(250)

Issue 5274047: Camera sensor size

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by nazgul
Modified:
7 years, 8 months ago
Reviewers:
bf-codereview, ideasman42, brechtvl
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

Implementation of configurable sensor size. It's a bit simplified version of patch originally provided by Matt Ebb (iirc) to deal properly with current render pipeline. Implementing all that filmgate things discussed in vfx mailing list will need to be supported by render engines.

Patch Set 1 #

Patch Set 2 : Updated patchset. Hope it'll work now #

Total comments: 13
Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -61 lines) Patch
release/scripts/presets/camera/APS-C_DSLR.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Blender.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Canon_1100D.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Canon_1D.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Canon_1DS.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Canon_500D.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Canon_550D.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Canon_5D.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Canon_600D.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Canon_60D.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Canon_7D.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Nikon_D300S.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Nikon_D3100.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Nikon_D35.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Nikon_D5000.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Nikon_D5100.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Nikon_D7000.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Nikon_D90.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Red_Epic.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Red_One_2K.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Red_One_3K.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/Red_One_4K.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/full_frame_35mm_film.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/micro_four_thirds.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/super_16_film.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/presets/camera/super_35_film.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
release/scripts/startup/bl_operators/presets.py View 1 1 chunk +17 lines, -0 lines 0 comments Download
release/scripts/startup/bl_ui/properties_data_camera.py View 1 5 chunks +44 lines, -17 lines 0 comments Download
source/blender/blenkernel/BKE_object.h View 1 1 chunk +1 line, -1 line 0 comments Download
source/blender/blenkernel/intern/object.c View 1 5 chunks +6 lines, -4 lines 1 comment Download
source/blender/blenlib/BLI_math_rotation.h View 1 1 chunk +2 lines, -2 lines 2 comments Download
source/blender/blenlib/intern/math_rotation.c View 1 1 chunk +4 lines, -4 lines 0 comments Download
source/blender/blenlib/intern/uvproject.c View 1 1 chunk +1 line, -1 line 0 comments Download
source/blender/blenloader/intern/readfile.c View 1 1 chunk +9 lines, -0 lines 0 comments Download
source/blender/collada/CameraExporter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
source/blender/collada/DocumentImporter.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
source/blender/editors/sculpt_paint/paint_image.c View 1 2 chunks +2 lines, -2 lines 0 comments Download
source/blender/editors/space_view3d/view3d_draw.c View 1 3 chunks +22 lines, -4 lines 0 comments Download
source/blender/editors/space_view3d/view3d_view.c View 1 4 chunks +6 lines, -5 lines 2 comments Download
source/blender/makesdna/DNA_camera_types.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
source/blender/makesrna/intern/rna_camera.c View 1 5 chunks +31 lines, -12 lines 3 comments Download
source/blender/modifiers/intern/MOD_uvproject.c View 1 3 chunks +10 lines, -1 line 3 comments Download
source/blender/render/intern/include/render_types.h View 1 1 chunk +1 line, -0 lines 0 comments Download
source/blender/render/intern/source/envmap.c View 1 1 chunk +1 line, -0 lines 0 comments Download
source/blender/render/intern/source/initrender.c View 1 1 chunk +1 line, -1 line 0 comments Download
source/gameengine/Converter/BL_BlenderDataConversion.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
source/gameengine/Ketsji/KX_Camera.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
source/gameengine/Ketsji/KX_Camera.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
source/gameengine/Ketsji/KX_KetsjiEngine.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
source/gameengine/Rasterizer/RAS_CameraData.h View 1 2 chunks +3 lines, -1 line 0 comments Download
source/gameengine/Rasterizer/RAS_FramingManager.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
source/gameengine/Rasterizer/RAS_FramingManager.cpp View 1 4 chunks +5 lines, -1 line 2 comments Download
source/gameengine/VideoTexture/ImageRender.cpp View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10
nazgul
7 years, 8 months ago (2011-10-15 16:46:24 UTC) #1
nazgul
Updated patchset. Hope it'll work now
7 years, 8 months ago (2011-10-15 18:33:18 UTC) #2
brechtvl
Sorry to bring this up again, but I'm still a bit confused by the sensor ...
7 years, 8 months ago (2011-10-19 13:14:15 UTC) #3
nazgul
I'm not sure about "standard" pipeline -- when it's needed to know exact settings of ...
7 years, 8 months ago (2011-10-19 13:54:24 UTC) #4
brechtvl
Also mailed bf-vfx about aspect ratio question, I'll review the full sensor patch, hopefully that ...
7 years, 8 months ago (2011-10-19 14:09:09 UTC) #5
nazgul
Yeah, saw your mail. Thanks for help here. It's not more about difficulty of changes, ...
7 years, 8 months ago (2011-10-19 14:19:31 UTC) #6
ideasman42
patch looks good, would rename all references to width / x --> size, some other ...
7 years, 8 months ago (2011-10-20 12:43:41 UTC) #7
nazgul
http://codereview.appspot.com/5274047/diff/4001/source/blender/modifiers/intern/MOD_uvproject.c File source/blender/modifiers/intern/MOD_uvproject.c (right): http://codereview.appspot.com/5274047/diff/4001/source/blender/modifiers/intern/MOD_uvproject.c#newcode171 source/blender/modifiers/intern/MOD_uvproject.c:171: sensor_x= camera->sensor_x; I'm not sure what "referenced from the ...
7 years, 8 months ago (2011-10-20 16:04:50 UTC) #8
ideasman42
Clarified comment about UV-project modifier. http://codereview.appspot.com/5274047/diff/4001/source/blender/modifiers/intern/MOD_uvproject.c File source/blender/modifiers/intern/MOD_uvproject.c (right): http://codereview.appspot.com/5274047/diff/4001/source/blender/modifiers/intern/MOD_uvproject.c#newcode171 source/blender/modifiers/intern/MOD_uvproject.c:171: sensor_x= camera->sensor_x; On 2011/10/20 ...
7 years, 8 months ago (2011-10-20 21:45:13 UTC) #9
brechtvl
7 years, 7 months ago (2011-11-01 18:44:51 UTC) #10
After latest changes in tomato branch, I'm not aware of any remaining issues,
so: LGTM :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b