Issue 5272050: code review 5272050: 6l, 8l: emit macho dwarf info before linkedit section

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5272050: code review 5272050: 6l, 8l: emit macho dwarf info before linkedit section (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by mkrautz

Modified:
15 years ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

6l, 8l: emit macho dwarf info before linkedit section

Patch Set 1 #

Patch Set 2 : diff -r 89266ada32fb https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 89266ada32fb https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 89266ada32fb https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 89266ada32fb https://go.googlecode.com/hg/ #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -7 lines)			Patch
M	src/cmd/6l/asm.c	View	1	3 chunks	+13 lines, -3 lines	0 comments	Download
M	src/cmd/8l/asm.c	View	1	3 chunks	+13 lines, -3 lines	0 comments	Download
M	src/cmd/ld/lib.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/ld/macho.c	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

mkrautz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

15 years ago (2011-10-15 15:23:45 UTC) #1

mkrautz

On 2011/10/15 15:23:45, mkrautz wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...

15 years ago (2011-10-15 15:27:31 UTC) #2

rsc

ignore this; my mail threading was off. On Tue, Oct 18, 2011 at 15:48, Russ ...

15 years ago (2011-10-18 19:48:27 UTC) #4

rsc

15 years ago (2011-10-18 19:58:13 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=f2fca0f2c8b2 ***

6l, 8l: emit macho dwarf info before linkedit section

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5272050

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages