Issue 5271050: code review 5271050: ld: modify macho linkedit segment to enable OS X code s...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5271050: code review 5271050: ld: modify macho linkedit segment to enable OS X code s... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by mkrautz

Modified:
15 years ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

ld: modify macho linkedit segment to enable OS X code signing Move string table to the end of the __LINKEDIT segment. This change allows Apple's codesign(1) utility to successfully sign Go binaries, as long as they don't contain DWARF data (-w flag to 8l/6l). This is because codesign(1) expects the string table to be the last part of the file.

Patch Set 1 #

Patch Set 2 : diff -r 89266ada32fb https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 89266ada32fb https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 89266ada32fb https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 89266ada32fb https://go.googlecode.com/hg/ #

Created: 15 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	src/cmd/ld/macho.c	View	1 2 3	4 chunks	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mkrautz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

15 years ago (2011-10-15 13:02:26 UTC) #1

mkrautz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

15 years ago (2011-10-15 13:05:53 UTC) #2

rsc

15 years ago (2011-10-18 20:31:06 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=3213129c689b ***

ld: modify macho linkedit segment to enable OS X code signing

Move string table to the end of the __LINKEDIT segment.

This change allows Apple's codesign(1) utility to successfully sign
Go binaries, as long as they don't contain DWARF data (-w flag to
8l/6l).  This is because codesign(1) expects the string table to be
the last part of the file.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5271050

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages