Issue 5271054: implement soft clipping (check-point)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5271054: implement soft clipping (check-point)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by reed1

Modified:
12 years, 6 months ago

Reviewers:

CC:
bsalomon, bungeman, TomH, caryclark1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : more #

Patch Set 4 : more #

Patch Set 5 : more #

Patch Set 6 : more #

Patch Set 7 : add lcd16,lcd32 #

Patch Set 8 : hairpoints, drawpostext #

Patch Set 9 : maskfilters, antifillxrect #

Patch Set 10 : inverseFill #

Patch Set 11 : 3d-maskformat, pre-chop rects before building aaclips in op #

Patch Set 12 : asdf #

Patch Set 13 : optimize op+irect and optimize building irect->aaclip #

Patch Set 14 : more op+irect optimizations #

Patch Set 15 : add trimBounds, fix memory overwrite in blitMask #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1292 lines, -403 lines)			Patch
M	include/core/SkDraw.h	View	1 2 3 4 5 6 7 8 9 10	2 chunks	+3 lines, -1 line	0 comments	Download
M	include/core/SkMaskFilter.h	View	1 2 3 4 5 6 7 8 9 10	3 chunks	+12 lines, -9 lines	0 comments	Download
M	include/core/SkScan.h	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+47 lines, -37 lines	0 comments	Download
M	samplecode/SampleAAClip.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+2 lines, -0 lines	0 comments	Download
M	samplecode/SampleAAClip2.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	2 chunks	+4 lines, -0 lines	0 comments	Download
M	samplecode/SampleApp.cpp	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+1 line, -1 line	0 comments	Download
M	samplecode/SampleClip.cpp	View	1 2 3 4 5 6 7 8 9 10	2 chunks	+69 lines, -19 lines	0 comments	Download
M	samplecode/SampleFuzz.cpp	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+0 lines, -1 line	0 comments	Download
M	samplecode/SampleXfermodesBlur.cpp	View	1 2 3 4 5 6 7 8 9 10	2 chunks	+25 lines, -0 lines	0 comments	Download
M	src/core/SkAAClip.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	4 chunks	+20 lines, -3 lines	0 comments	Download
M	src/core/SkAAClip.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	28 chunks	+525 lines, -105 lines	0 comments	Download
M	src/core/SkCanvas.cpp	View	1 2 3 4 5 6 7 8 9 10	6 chunks	+10 lines, -10 lines	0 comments	Download
M	src/core/SkDraw.cpp	View	1 2 3 4 5 6 7 8 9 10	47 chunks	+197 lines, -125 lines	0 comments	Download
M	src/core/SkDrawProcs.h	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/core/SkMaskFilter.cpp	View	1 2 3 4 5 6 7 8 9 10	3 chunks	+7 lines, -3 lines	0 comments	Download
M	src/core/SkRasterClip.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	3 chunks	+70 lines, -0 lines	0 comments	Download
M	src/core/SkRasterClip.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	10 chunks	+82 lines, -3 lines	0 comments	Download
M	src/core/SkScalerContext.cpp	View	1 2 3 4 5 6 7 8 9 10	3 chunks	+5 lines, -4 lines	0 comments	Download
M	src/core/SkScan.cpp	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+35 lines, -6 lines	0 comments	Download
M	src/core/SkScan_AntiPath.cpp	View	1 2 3 4 5 6 7 8 9 10	3 chunks	+9 lines, -2 lines	0 comments	Download
M	src/core/SkScan_Antihair.cpp	View	1 2 3 4 5 6 7 8 9 10	6 chunks	+54 lines, -33 lines	0 comments	Download
M	src/core/SkScan_Hairline.cpp	View	1 2 3 4 5 6 7 8 9 10	7 chunks	+81 lines, -22 lines	0 comments	Download
M	src/core/SkScan_Path.cpp	View	1 2 3 4 5 6 7 8 9 10	4 chunks	+20 lines, -4 lines	0 comments	Download
M	src/effects/Sk2DPathEffect.cpp	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/effects/SkLayerRasterizer.cpp	View	1 2 3 4 5 6 7 8 9 10	3 chunks	+9 lines, -8 lines	0 comments	Download
M	tests/FillPathTest.cpp	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

reed1

12 years, 6 months ago (2011-10-21 20:25:51 UTC) #1

for your viewing pleasure.

Passes our gm
Passes DRT (on linux anyway)
Runs locally on my Mac Chrome Skia build (Shark looks fine scrolling gmail)

softclipping is an opt-in feature, so no changes are expected in Chrome until we
change its calls to clipPath.

Expand All Messages | Collapse All Messages