Issue 52550045: apiserver: FirewallerAPI server-side API facade

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 52550045: apiserver: FirewallerAPI server-side API facade (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by dimitern

Modified:
10 years, 3 months ago

Reviewers:
mp+202424, rog

Visibility:
Public.

Description

apiserver: FirewallerAPI server-side API facade Complete implementation of the server-side API for the firewaller, including tests. Using as much of the mixins in apiserver/common/ as possible to reduce code duplication. This is the last CL in the chain. Next the client-side will be worked on. https://code.launchpad.net/~dimitern/juju-core/237-apiserver-firewaller/+merge/202424 Requires: https://code.launchpad.net/~dimitern/juju-core/236-apiserver-common-instanceidgetter/+merge/202352 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : apiserver: FirewallerAPI server-side API facade #

Total comments: 2

Patch Set 3 : apiserver: FirewallerAPI server-side API facade #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+749 lines, -53 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/api/params/internal.go	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	state/apiserver/common/environmachineswatcher.go	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	state/apiserver/common/environwatcher.go	View	1 2	4 chunks	+9 lines, -6 lines	0 comments	Download
M	state/apiserver/common/environwatcher_test.go	View	1 2	8 chunks	+29 lines, -24 lines	0 comments	Download
M	state/apiserver/common/interfaces.go	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download
M	state/apiserver/deployer/deployer.go	View	1 2	1 chunk	+1 line, -7 lines	0 comments	Download
A	state/apiserver/firewaller/firewaller.go	View	1 2	1 chunk	+208 lines, -0 lines	0 comments	Download
A	state/apiserver/firewaller/firewaller_test.go	View		1 chunk	+460 lines, -0 lines	0 comments	Download
M	state/apiserver/provisioner/provisioner.go	View	1 2	1 chunk	+4 lines, -12 lines	0 comments	Download
M	state/apiserver/testing/errors.go	View		2 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

LGTM https://codereview.appspot.com/52550045/diff/20001/state/apiserver/firewaller/firewaller.go File state/apiserver/firewaller/firewaller.go (right): https://codereview.appspot.com/52550045/diff/20001/state/apiserver/firewaller/firewaller.go#newcode38 state/apiserver/firewaller/firewaller.go:38: // Setup the various authorization checkers. s/Setup/Set up/

10 years, 3 months ago (2014-01-21 16:52:17 UTC) #3

dimitern

10 years, 3 months ago (2014-01-21 17:58:32 UTC) #4

Please take a look.

https://codereview.appspot.com/52550045/diff/20001/state/apiserver/firewaller...
File state/apiserver/firewaller/firewaller.go (right):

https://codereview.appspot.com/52550045/diff/20001/state/apiserver/firewaller...
state/apiserver/firewaller/firewaller.go:38: // Setup the various authorization
checkers.
On 2014/01/21 16:52:17, rog wrote:
> s/Setup/Set up/

Done.

Expand All Messages | Collapse All Messages