Issue 52500043: code review 52500043: go.tools/go/types: minor cleanups

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 52500043: code review 52500043: go.tools/go/types: minor cleanups (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by gri

Modified:
11 years, 5 months ago

Reviewers:
adonovan

CC:
adonovan, golang-codereviews

Visibility:
Public.

Description

go.tools/go/types: minor cleanups - remove TODO in exact.go - use testing.Verbose() rather than local verbose flag

Patch Set 1 #

Patch Set 2 : diff -r 732451e4158d https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 732451e4158d https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 36d725dd35ff https://code.google.com/p/go.tools #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	go/exact/exact.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
	M	go/types/stdlib_test.go	View	1	4 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello adonovan@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

11 years, 5 months ago (2014-01-15 01:09:15 UTC) #1

adonovan

On 2014/01/15 01:09:15, gri wrote: > Hello mailto:adonovan@google.com (cc: mailto:golang-codereviews@googlegroups.com), > > I'd like you ...

11 years, 5 months ago (2014-01-15 01:51:50 UTC) #2

gri

11 years, 5 months ago (2014-01-15 05:04:34 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=4ee2336182a0&repo=tools ***

go.tools/go/types: minor cleanups

- remove TODO in exact.go
- use testing.Verbose() rather than local verbose flag

R=adonovan
CC=golang-codereviews
https://codereview.appspot.com/52500043

Expand All Messages | Collapse All Messages