Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(237)

Issue 5247044: [pph] Make pph.h _the_ interface header. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by Lawrence Crowl
Modified:
9 years, 11 months ago
Reviewers:
Diego Novillo
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/pph/
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -184 lines) Patch
M gcc/cp/Make-lang.in View 6 chunks +10 lines, -11 lines 0 comments Download
M gcc/cp/decl.c View 2 chunks +1 line, -1 line 0 comments Download
M gcc/cp/name-lookup.c View 1 chunk +0 lines, -1 line 0 comments Download
M gcc/cp/parser.c View 1 chunk +0 lines, -1 line 0 comments Download
M gcc/cp/pph.h View 2 chunks +141 lines, -31 lines 0 comments Download
M gcc/cp/pph-streamer.h View 9 chunks +8 lines, -138 lines 1 comment Download
M gcc/cp/pph-streamer-in.c View 1 chunk +1 line, -0 lines 0 comments Download
M gcc/cp/pph-streamer-out.c View 1 chunk +1 line, -0 lines 0 comments Download
M gcc/cp/semantics.c View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Lawrence Crowl
This patch makes pph.h the single interface header for PPH. The pph-streamer.h header is now ...
10 years, 7 months ago (2011-10-08 03:29:34 UTC) #1
Diego Novillo
http://codereview.appspot.com/5247044/diff/1/gcc/cp/pph-streamer.h File gcc/cp/pph-streamer.h (right): http://codereview.appspot.com/5247044/diff/1/gcc/cp/pph-streamer.h#newcode165 gcc/cp/pph-streamer.h:165: struct pph_stream { 165 struct pph_stream { You need ...
10 years, 7 months ago (2011-10-11 12:31:24 UTC) #2
Diego Novillo
10 years, 7 months ago (2011-10-11 19:33:54 UTC) #3
On Tue, Oct 11, 2011 at 08:31,  <dnovillo@google.com> wrote:
>
> http://codereview.appspot.com/5247044/diff/1/gcc/cp/pph-streamer.h
> File gcc/cp/pph-streamer.h (right):
>
> http://codereview.appspot.com/5247044/diff/1/gcc/cp/pph-streamer.h#newcode165
> gcc/cp/pph-streamer.h:165: struct pph_stream {
> 165 struct pph_stream {
>
> You need the typedef.  Stage 1 is still built with C.
>
> http://codereview.appspot.com/5247044/
>
And the typedef is in pph.h now.  Ignore me.  I'm blind.


Diego.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b