Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5293)

Issue 52440044: Removed duplicate files. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by pajamallama
Modified:
10 years, 3 months ago
Reviewers:
tapted
CC:
chrome-apps-internsyd_google.com
Base URL:
https://github.com/tapted/bleeding_edge.git@master
Visibility:
Public.

Description

Removed duplicate files. Now make will compile the dart to js/pubchrome.dart.precompiled.js and js/browser.js will allow both Dartium & Chrome to open the app. R=tapted@chromium.org Committed: https://github.com/tapted/bleeding_edge/commit/9bb444e

Patch Set 1 #

Patch Set 2 : Removed bug where pub called every make #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -270 lines) Patch
M dart/sdk/lib/_internal/pub/.gitignore View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/sdk/lib/_internal/pub/Makefile View 1 1 chunk +12 lines, -11 lines 5 comments Download
D dart/sdk/lib/_internal/pub/app/Makefile View 1 chunk +0 lines, -17 lines 0 comments Download
D dart/sdk/lib/_internal/pub/app/images/dart_icon.png View Binary file 0 comments Download
D dart/sdk/lib/_internal/pub/app/js/.gitignore View 1 chunk +0 lines, -1 line 0 comments Download
D dart/sdk/lib/_internal/pub/app/js/archive.js View 1 chunk +0 lines, -74 lines 0 comments Download
D dart/sdk/lib/_internal/pub/app/js/browser.js View 1 chunk +0 lines, -41 lines 0 comments Download
D dart/sdk/lib/_internal/pub/app/js/main.js View 1 chunk +0 lines, -17 lines 0 comments Download
D dart/sdk/lib/_internal/pub/app/manifest.json View 1 chunk +0 lines, -18 lines 0 comments Download
D dart/sdk/lib/_internal/pub/app/pub.html View 1 chunk +0 lines, -26 lines 0 comments Download
D dart/sdk/lib/_internal/pub/app/pubspec.yaml View 1 chunk +0 lines, -15 lines 0 comments Download
D dart/sdk/lib/_internal/pub/app/style.css View 1 chunk +0 lines, -42 lines 0 comments Download
M dart/sdk/lib/_internal/pub/js/archive.js View 1 chunk +6 lines, -0 lines 0 comments Download
M dart/sdk/lib/_internal/pub/manifest.json View 2 chunks +3 lines, -5 lines 0 comments Download
M dart/sdk/lib/_internal/pub/style.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
pajamallama
10 years, 3 months ago (2014-01-15 01:01:43 UTC) #1
tapted
lgtm https://codereview.appspot.com/52440044/diff/20001/dart/sdk/lib/_internal/pub/Makefile File dart/sdk/lib/_internal/pub/Makefile (right): https://codereview.appspot.com/52440044/diff/20001/dart/sdk/lib/_internal/pub/Makefile#newcode8 dart/sdk/lib/_internal/pub/Makefile:8: lib/src/packages: lib/src/pubspec.yaml directory timestamps can be a bit ...
10 years, 3 months ago (2014-01-15 02:55:42 UTC) #2
pajamallama
Committed patchset #2 manually as r9bb444e (presubmit successful).
10 years, 3 months ago (2014-01-15 03:21:34 UTC) #3
pajamallama
Can make these changes in a separate CL if necessary.. https://codereview.appspot.com/52440044/diff/20001/dart/sdk/lib/_internal/pub/Makefile File dart/sdk/lib/_internal/pub/Makefile (right): https://codereview.appspot.com/52440044/diff/20001/dart/sdk/lib/_internal/pub/Makefile#newcode8 ...
10 years, 3 months ago (2014-01-15 03:22:05 UTC) #4
tapted
10 years, 3 months ago (2014-01-15 04:54:26 UTC) #5
Message was sent while issue was closed.
https://codereview.appspot.com/52440044/diff/20001/dart/sdk/lib/_internal/pub...
File dart/sdk/lib/_internal/pub/Makefile (right):

https://codereview.appspot.com/52440044/diff/20001/dart/sdk/lib/_internal/pub...
dart/sdk/lib/_internal/pub/Makefile:8: lib/src/packages: lib/src/pubspec.yaml
On 2014/01/15 03:22:05, pajamallama wrote:
> On 2014/01/15 02:55:42, tapted wrote:
> > directory timestamps can be a bit funny. If you want this to be run only
when
> > pubspec.yaml changes, you can `touch` a file in lib/src/packages on a
> > successfuly `pub get`, and depend on that.
> > 
> > E.g.
> > 
> > lib/src/packages/.pub-get-lastrun: lib/src/pubspec.yaml
> >         cd lib/src/ && pub get && touch packages/.pub-get-lastrun
> > 
> > then if timestamp(.pub-get-lastrun) < timestamp(pubspec.yaml), it will run
> `pub
> > get` again
> 
> Hmmmmmmmmmmmm. The current way seems to work..?

Hrm - I guess it works because `pub get` blows away the packages directory
completely each time it runs.  But I think we saw a TODO in pub to not actually
do this. But yeah, fine until it breaks I guess.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b