Issue 52360043: code review 52360043: reflect: better document the tri-state for TryRecv

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 52360043: code review 52360043: reflect: better document the tri-state for TryRecv (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by r

Modified:
11 years, 5 months ago

Reviewers:
iant

CC:
rsc, iant, golang-codereviews

Visibility:
Public.

Description

reflect: better document the tri-state for TryRecv

Patch Set 2 : diff -r 471bbae6c688 https://code.google.com/p/go #

Patch Set 3 : diff -r 471bbae6c688 https://code.google.com/p/go #

Patch Set 4 : diff -r a56fc8d6a7ea https://code.google.com/p/go #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/pkg/reflect/value.go	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 5 months ago (2014-01-14 22:38:13 UTC) #1

iant

https://codereview.appspot.com/52360043/diff/1/src/pkg/reflect/value.go File src/pkg/reflect/value.go (right): https://codereview.appspot.com/52360043/diff/1/src/pkg/reflect/value.go#newcode1836 src/pkg/reflect/value.go:1836: // If the receive cannot finish without blocking, x ...

11 years, 5 months ago (2014-01-14 22:55:18 UTC) #2

Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.

11 years, 5 months ago (2014-01-14 22:58:32 UTC) #3

11 years, 5 months ago (2014-01-14 22:58:35 UTC) #4

11 years, 5 months ago (2014-01-14 23:03:50 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=cfeddd20036d ***

reflect: better document the tri-state for TryRecv

R=rsc, iant
CC=golang-codereviews
https://codereview.appspot.com/52360043

Expand All Messages | Collapse All Messages