Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2246)

Issue 5229042: Add getLastMethod() to goog.testing.net.XhrIo

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by Rich Dougherty
Modified:
2 years, 6 months ago
Reviewers:
Peter Pallos
Base URL:
http://closure-library.googlecode.com/svn/trunk/
Visibility:
Public.

Description

When testing with goog.testing.net.XhrIo we can use the getLastXxx() methods to
find the parameters that were used in the last send() call. There are methods
for accessing all but one of send()'s parameters. Unfortunately access to the
'method' parameter is missing. I'd like to be able to test that my code is using
the correct method (e.g. 'PUT') so I've written a patch that adds
getLastMethod() to access that information.

This is my first patch (albeit small) so I'm also including an entry in the
AUTHORS file as instructed by
http://code.google.com/p/closure-library/wiki/Contributors.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Made suggested changes. Also made same changes to other lastXxx members for consistency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -11 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M closure/goog/testing/net/xhrio.js View 1 4 chunks +20 lines, -2 lines 0 comments Download
M closure/goog/testing/net/xhrio_test.html View 1 2 chunks +21 lines, -9 lines 0 comments Download

Messages

Total messages: 3
Peter Pallos
http://codereview.appspot.com/5229042/diff/1/closure/goog/testing/net/xhrio.js File closure/goog/testing/net/xhrio.js (right): http://codereview.appspot.com/5229042/diff/1/closure/goog/testing/net/xhrio.js#newcode159 closure/goog/testing/net/xhrio.js:159: goog.testing.net.XhrIo.prototype.lastMethod_ = undefined; You can leave lastMethod_ uninitialized. It ...
2 years, 6 months ago #1
Rich Dougherty
Thanks for the quick review! Replying here because I'm not sure if you're notified when ...
2 years, 6 months ago #2
Peter Pallos
2 years, 6 months ago #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5