Issue 52130043: environs: Remove local charm cache on destroy

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 52130043: environs: Remove local charm cache on destroy (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by dimitern

Modified:
10 years, 4 months ago

Reviewers:
gz, mp+201612

Visibility:
Public.

Description

environs: Remove local charm cache on destroy Fixes bug #1259925: Local charm cache directory in JUJU_HOME now gets removed when the environment is destroyed. https://code.launchpad.net/~dimitern/juju-core/231-charmcache-not-removed-on-destroyenv-1259925/+merge/201612 Requires: https://code.launchpad.net/~dimitern/juju-core/230-cache-bootstrap-address-1268471/+merge/201593 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : environs: Remove local charm cache on destroy #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -8 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine.go	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	cmd/jujud/machine_test.go	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	environs/open.go	View		4 chunks	+12 lines, -2 lines	0 comments	Download
M	environs/open_test.go	View	1	3 chunks	+20 lines, -2 lines	0 comments	Download
M	juju/conn.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	juju/conn_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

LGTM. https://codereview.appspot.com/52130043/diff/1/environs/open_test.go File environs/open_test.go (right): https://codereview.appspot.com/52130043/diff/1/environs/open_test.go#newcode295 environs/open_test.go:295: // Create teh charm cache dir and put ...

10 years, 4 months ago (2014-01-14 15:48:10 UTC) #2

dimitern

Please take a look. https://codereview.appspot.com/52130043/diff/1/environs/open_test.go File environs/open_test.go (right): https://codereview.appspot.com/52130043/diff/1/environs/open_test.go#newcode295 environs/open_test.go:295: // Create teh charm cache ...

10 years, 4 months ago (2014-01-15 11:27:59 UTC) #3

dimitern

10 years, 4 months ago (2014-01-15 14:22:03 UTC) #4

I decided to drop this branch and mark the bug as Fix Committed, because it
seems the local provider cleans up the charmcache along with its other artifacts
upon destruction.

Expand All Messages | Collapse All Messages