Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

Issue 52110044: code review 52110044: reflect: give proper types to the argument/return areas (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 3 months ago by khr
Modified:
1 year, 3 months ago
Reviewers:
rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

reflect: add precise GC info for Call argument frame. Give proper types to the argument/return areas allocated for reflect calls. Avoid use of iword to manipulate receivers, which may or may not be pointers. Update issue 6490

Patch Set 1 #

Patch Set 2 : diff -r ecccf07e7f9d https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r ecccf07e7f9d https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r ecccf07e7f9d https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 5 : diff -r 889628c63997 https://khr%40golang.org@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -97 lines) Patch
M src/pkg/reflect/type.go View 1 2 1 chunk +91 lines, -0 lines 0 comments Download
M src/pkg/reflect/value.go View 1 8 chunks +68 lines, -97 lines 0 comments Download

Messages

Total messages: 5
khr
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/
1 year, 3 months ago (2014-01-14 19:18:04 UTC) #1
gobot
Replacing golang-dev with golang-codereviews. To the author of this CL: If you are using 'hg ...
1 year, 3 months ago (2014-01-14 19:21:34 UTC) #2
rsc
LGTM in general the first line of the CL description should stand alone, so that ...
1 year, 3 months ago (2014-01-15 04:40:42 UTC) #3
khr
On 2014/01/15 04:40:42, rsc wrote: > LGTM > > in general the first line of ...
1 year, 3 months ago (2014-01-15 21:54:17 UTC) #4
khr
1 year, 3 months ago (2014-01-15 21:57:00 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=761cf9b4e530 ***

reflect: add precise GC info for Call argument frame.

Give proper types to the argument/return areas
allocated for reflect calls.  Avoid use of iword to
manipulate receivers, which may or may not be pointers.

Update issue 6490

R=rsc
CC=golang-codereviews
https://codereview.appspot.com/52110044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e6eadc5