Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1801)

Issue 5201043: Creates a LeftBarStub that stops lyrics from bumping into the SystemStartBar.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by MikeSol
Modified:
7 years, 8 months ago
Reviewers:
pkx166h, Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Creates a LeftBarStub that stops lyrics from bumping into the SystemStartBar.

Patch Set 1 #

Patch Set 2 : Fixes problem with erroneous BarNumber shifts #

Total comments: 1

Patch Set 3 : Allows extremal LeftBarStubs to be flush with system start. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -5 lines) Patch
A input/regression/lyric-left-edge.ly View 1 chunk +21 lines, -0 lines 0 comments Download
M lily/axis-group-engraver.cc View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M lily/hara-kiri-engraver.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M lily/hara-kiri-group-spanner.cc View 1 2 3 chunks +41 lines, -0 lines 0 comments Download
M lily/include/hara-kiri-group-spanner.hh View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M lily/item.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M lily/item-scheme.cc View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
A lily/left-bar-stub-engraver.cc View 1 1 chunk +72 lines, -0 lines 0 comments Download
M ly/engraver-init.ly View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M scm/define-context-properties.scm View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M scm/output-lib.scm View 1 2 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 6
pkx166h
passes make but I get a programming error show up on make check (as well ...
7 years, 8 months ago (2011-10-06 19:41:26 UTC) #1
MikeSol
On 2011/10/06 19:41:26, J_lowe wrote: > passes make but I get a programming error show ...
7 years, 8 months ago (2011-10-07 09:47:03 UTC) #2
pkx166h
Passes make and make check shows 2 reg test diffs that Mike seems to think ...
7 years, 8 months ago (2011-10-08 04:59:31 UTC) #3
Neil Puttock
http://codereview.appspot.com/5201043/diff/3001/scm/output-lib.scm File scm/output-lib.scm (right): http://codereview.appspot.com/5201043/diff/3001/scm/output-lib.scm#newcode355 scm/output-lib.scm:355: (if (eq? 0 (ly:item-break-dir grob)) Doesn't this potentially make ...
7 years, 8 months ago (2011-10-08 16:41:52 UTC) #4
MikeSol
This new patch set eliminates all regtest diffs via a mechanism that allows extremal lyrics ...
7 years, 8 months ago (2011-10-10 10:29:26 UTC) #5
MikeSol
7 years, 8 months ago (2011-10-10 11:13:00 UTC) #6
I got a little ahead of myself...the patch, while it works in the regtest cases,
does not work the way I think it did because all Items' pure heights are
calculated from 0 to INT_MAX in Separation_item::boxes.

Certain NonMusicalPaperColumns' horizontal skylines will change depending on if
they begin a line or not.  It seems, though, that Separation_item does a
one-size-fits-all calculation for the minimum distance between
NonMusicalPaperColumns and PaperColumns.  So, my questions are: do
NonMusicalPaperColumns have different horizontal skylines for different break
visibilities?  If so, where are they stashed?  If not, how does the horizontal
spacing engine know how to deal with changing break visibilities for different
start and end columns?  I'm thinking that Line_shape may have something to do
with it, but I'm not sure.  Help would be appreciated!

Cheers,
MS
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b