Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8041)

Issue 5176042: VIEWER: Add toggle to determine correct glBlendFunc with regards to associated or unassociated alpha

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by troy_s
Modified:
9 years, 7 months ago
Reviewers:
lukas.toenne, bf-codereview
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M release/datafiles/blenderbuttons View Binary file 0 comments Download
M release/scripts/startup/bl_ui/space_image.py View 1 chunk +4 lines, -0 lines 0 comments Download
M source/blender/editors/include/UI_icons.h View 1 chunk +1 line, -1 line 0 comments Download
M source/blender/editors/space_image/image_draw.c View 1 chunk +5 lines, -1 line 0 comments Download
M source/blender/makesdna/DNA_space_types.h View 1 chunk +1 line, -0 lines 0 comments Download
M source/blender/makesrna/intern/rna_space.c View 1 chunk +6 lines, -0 lines 1 comment Download

Messages

Total messages: 3
troy_s
12 years, 7 months ago (2011-10-01 17:04:19 UTC) #1
lukas.toenne
Looks good for this purpose, only suggest that one rename. From a design perspective i'm ...
12 years, 7 months ago (2011-10-03 13:10:58 UTC) #2
troy_s
12 years, 7 months ago (2011-10-03 13:24:46 UTC) #3
> From a design perspective i'm not sure how this should work ideally. Making
the
> user select the alpha mode of the image sounds like a cheap way out of the
whole
> alpha premul mess. At least this could be stored per image, so the user has to
> define that only once when loading an image (reasonable default is another
> question then).

I thought this originally and then turned around on it.

The reason is artist control.

If we assume artists are manually decomposing and generating alphas and
multiplying / dividing as required via math or other nodes, we would then put
the onus on the artist to correctly flag every instance of their alpha. Common
cases would be rotoscope and matte painting decomposes and knockouts.

I strongly suspect that, despite initial reactions, this may very well be the
most elegant solution relative to artist simplicity.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b