Issue 51750044: code review 51750044: net/http: add disabled test for Body Read/Close lock gr...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 51750044: code review 51750044: net/http: add disabled test for Body Read/Close lock gr... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by bradfitz

Modified:
10 years, 3 months ago

Reviewers:
dsymonds, josharian

CC:
golang-codereviews, gobot, dsymonds

Visibility:
Public.

Description

net/http: add disabled test for Body Read/Close lock granularity Update Issue 7121

Patch Set 1 #

Patch Set 2 : diff -r 0337092aa784 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0337092aa784 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4df290191840 https://go.googlecode.com/hg/ #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -0 lines)			Patch
	M	src/pkg/net/http/serve_test.go	View	1	1 chunk	+51 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 3 months ago (2014-01-14 00:34:00 UTC) #1

bradfitz

Sputum? On Wed, Jan 15, 2014 at 1:10 PM, <dsymonds@golang.org> wrote: > LGTM > > ...

10 years, 3 months ago (2014-01-15 21:12:04 UTC) #4

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=889628c63997 *** net/http: add disabled test for Body Read/Close lock granularity Update ...

10 years, 3 months ago (2014-01-15 21:12:36 UTC) #6

josharian

10 years, 3 months ago (2014-01-15 21:42:16 UTC) #7

> Sounds Plausible To Me

Related: urbandictionary.com lists SGTM as "Silently giggling to
myself". Makes for delightful ambiguity.

-josh

Expand All Messages | Collapse All Messages