Add android sample for analytics v3 management api

[jsoneja, 2011-09-30 00:12:05]

http://codereview.appspot.com/5167041/diff/1/analytics-android-sample/src/mai...
File
analytics-android-sample/src/main/java/com/google/api/client/sample/analytics/android/AnalyticsSample.java
(right):

http://codereview.appspot.com/5167041/diff/1/analytics-android-sample/src/mai...
analytics-android-sample/src/main/java/com/google/api/client/sample/analytics/android/AnalyticsSample.java:51:
* @author Srinivasan Kannan (Based on Yaniv Inbar Calendar Sample)
Since this is going to be public, I think you can delete the comment in the
bracket.

http://codereview.appspot.com/5167041/diff/1/analytics-android-sample/src/mai...
analytics-android-sample/src/main/java/com/google/api/client/sample/analytics/android/AnalyticsSample.java:97:
Analytics analytics = new Analytics(transport, new HttpRequestInitializer() {
Store the request initializer in a local variable ? Would make the code a bit
more readable.

http://codereview.appspot.com/5167041/diff/1/analytics-android-sample/src/mai...
analytics-android-sample/src/main/java/com/google/api/client/sample/analytics/android/AnalyticsSample.java:129:
if (statusCode == 401) {
could this coupled with repeated auth failures lead to a infinite loop ?

[yanivi, 2011-10-17 17:08:17]

Sorry for the delay!  I've got a backlog of changesets to review, and I'm just
now starting to catch up.  This is next on my TODO list.  I do have a few
meaningful comments.

[yanivi, 2011-10-17 17:09:37]

A few comments to start off.  Ravi might also be able to help since he is the
new owner of the Java client library.

http://codereview.appspot.com/5167041/diff/1/analytics-android-sample/.project
File analytics-android-sample/.project (right):

http://codereview.appspot.com/5167041/diff/1/analytics-android-sample/.projec...
analytics-android-sample/.project:1: <?xml version="1.0" encoding="UTF-8"?>
We require all of our samples to have an instructions.html file (file name MUST
be exactly that) like this one:

http://code.google.com/p/google-api-java-client/source/browse/tasks-android-s...

http://codereview.appspot.com/5167041/diff/1/analytics-android-sample/src/mai...
File
analytics-android-sample/src/main/java/com/google/api/client/sample/analytics/android/AnalyticsSample.java
(right):

http://codereview.appspot.com/5167041/diff/1/analytics-android-sample/src/mai...
analytics-android-sample/src/main/java/com/google/api/client/sample/analytics/android/AnalyticsSample.java:51:
* @author Srinivasan Kannan (Based on Yaniv Inbar Calendar Sample)
On 2011/09/30 00:12:10, jsoneja wrote:
> Since this is going to be public, I think you can delete the comment in the
> bracket.

I agree.

http://codereview.appspot.com/5167041/diff/1/analytics-android-sample/src/mai...
analytics-android-sample/src/main/java/com/google/api/client/sample/analytics/android/AnalyticsSample.java:53:
public class AnalyticsSample extends ListActivity {
If you haven't already, please take a look at our Buzz and Tasks Android
samples:

http://code.google.com/p/google-api-java-client/source/browse/buzz-android-sa...

http://code.google.com/p/google-api-java-client/source/browse/tasks-android-s...

One particularly useful feature for debugging is the logging.  Take a look at
the JavaDoc on those classes.

http://codereview.appspot.com/5167041/diff/1/analytics-android-sample/src/mai...
analytics-android-sample/src/main/java/com/google/api/client/sample/analytics/android/AnalyticsSample.java:97:
Analytics analytics = new Analytics(transport, new HttpRequestInitializer() {
On 2011/09/30 00:12:10, jsoneja wrote:
> Store the request initializer in a local variable ? Would make the code a bit
> more readable.

You should probably use ClientLogin.Response, which basically does exactly this.
 You'll need to set the "auth" field.

http://codereview.appspot.com/5167041/diff/1/analytics-android-sample/src/mai...
analytics-android-sample/src/main/java/com/google/api/client/sample/analytics/android/AnalyticsSample.java:129:
if (statusCode == 401) {
On 2011/09/30 00:12:10, jsoneja wrote:
> could this coupled with repeated auth failures lead to a infinite loop ?

Yes.  The Calendar sample has this TODO:

      // TODO(yanivi): should only try this once to avoid infinite loop

Really we should only retry on a 401 once, and fail the second time.