Issue 5163044: Test failing for firefox with native events

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5163044: Test failing for firefox with native events

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by ahaas

Modified:
12 years, 7 months ago

Reviewers:
Eran

CC:
webdriver-eng_google.com

Visibility:
Public.

Description

The test fails because bot.dom.getInViewLocation, which is used in mouseMove, returns frame coordinates. The mouse location after mouseMove is then not stored in Window coordinates, which let the mouse click afterwards miss the intended button. The test can be fixed by calculating from frame coordinates to window coordinates. In chrome it works at the moment because it does not use bot.dom.getInViewLocation when the current frame is not the top frame.

Patch Set 1 #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	M	java/client/test/org/openqa/selenium/FrameSwitchingTest.java	View		2 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

ahaas

12 years, 7 months ago (2011-09-30 16:08:42 UTC) #1

A good first fix would be not to use the atom bot.dom.getInViewLocation when the
current frame is not the top frame. This fix works good in Chrome I would say. I
cannot commit a CL because the CL http://codereview.appspot.com/5124048/ is not
committed yet.

Expand All Messages | Collapse All Messages