Issue 51630043: code review 51630043: net/http: clarify semantics of File methods

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 51630043: code review 51630043: net/http: clarify semantics of File methods (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by bradfitz

Modified:
11 years, 6 months ago

Reviewers:
minux1

CC:
golang-codereviews, minux1

Visibility:
Public.

Description

net/http: clarify semantics of File methods There were no docs explaining the meaning of Readdir's count argument, for instance. Clarify that these mean the same as the methods on *os.File.

Patch Set 1 #

Patch Set 2 : diff -r 471bbae6c688 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 471bbae6c688 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 471bbae6c688 https://go.googlecode.com/hg/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	src/pkg/net/http/fs.go	View	1	1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 6 months ago (2014-01-13 21:22:50 UTC) #1

bradfitz

11 years, 6 months ago (2014-01-13 21:52:08 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=c6b6f2ed8daf ***

net/http: clarify semantics of File methods

There were no docs explaining the meaning of Readdir's count
argument, for instance. Clarify that these mean the same as
the methods on *os.File.

R=golang-codereviews, minux.ma
CC=golang-codereviews
https://codereview.appspot.com/51630043

Expand All Messages | Collapse All Messages