Issue 51580044: code review 51580044: syscall: add syscall.Termios on freebsd/{386,amd64}

Issue 51580044: code review 51580044: syscall: add syscall.Termios on freebsd/{386,amd64} (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by ebfe

Modified:
11 years, 5 months ago

Reviewers:
bradfitz

CC:
golang-codereviews, bradfitz, mg_ebfe.org

Visibility:
Public.

Description

syscall: add syscall.Termios on freebsd/{386,amd64}

Patch Set 1 #

Patch Set 2 : diff -r 753ca61a97d2 https://code.google.com/p/go #

Patch Set 3 : diff -r 471bbae6c688 https://code.google.com/p/go #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
M	src/pkg/syscall/types_freebsd.go	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/ztypes_freebsd_386.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/ztypes_freebsd_amd64.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

ebfe

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 6 months ago (2014-01-13 20:31:05 UTC) #1

bradfitz

You'll need to submit a CLA. See the contributing docs on the website. Let us ...

11 years, 6 months ago (2014-01-13 20:34:05 UTC) #2

You'll need to submit a CLA.  See the contributing docs on the website.

Let us know when you have and we can process it.




On Mon, Jan 13, 2014 at 12:31 PM, <gnirheg.leahcim@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> syscall: add syscall.Termios on freebsd/{386,amd64}
>
> Please review this at https://codereview.appspot.com/51580044/
>
> Affected files (+25, -0 lines):
>   M src/pkg/syscall/types_freebsd.go
>   M src/pkg/syscall/ztypes_freebsd_386.go
>   M src/pkg/syscall/ztypes_freebsd_amd64.go
>
>
> Index: src/pkg/syscall/types_freebsd.go
> ===================================================================
> --- a/src/pkg/syscall/types_freebsd.go
> +++ b/src/pkg/syscall/types_freebsd.go
> @@ -18,6 +18,7 @@
>  #include <dirent.h>
>  #include <fcntl.h>
>  #include <signal.h>
> +#include <termios.h>
>  #include <stdio.h>
>  #include <unistd.h>
>  #include <sys/event.h>
> @@ -248,3 +249,7 @@
>  type BpfHdr C.struct_bpf_hdr
>
>  type BpfZbufHeader C.struct_bpf_zbuf_header
> +
> +// Terminal handling
> +
> +type Termios C.struct_termios
> Index: src/pkg/syscall/ztypes_freebsd_386.go
> ===================================================================
> --- a/src/pkg/syscall/ztypes_freebsd_386.go
> +++ b/src/pkg/syscall/ztypes_freebsd_386.go
> @@ -443,3 +443,13 @@
>         User_gen   uint32
>         X_bzh_pad  [5]uint32
>  }
> +
> +type Termios struct {
> +       Iflag  uint32
> +       Oflag  uint32
> +       Cflag  uint32
> +       Lflag  uint32
> +       Cc     [20]uint8
> +       Ispeed uint32
> +       Ospeed uint32
> +}
> Index: src/pkg/syscall/ztypes_freebsd_amd64.go
> ===================================================================
> --- a/src/pkg/syscall/ztypes_freebsd_amd64.go
> +++ b/src/pkg/syscall/ztypes_freebsd_amd64.go
> @@ -446,3 +446,13 @@
>         User_gen   uint32
>         X_bzh_pad  [5]uint32
>  }
> +
> +type Termios struct {
> +       Iflag  uint32
> +       Oflag  uint32
> +       Cflag  uint32
> +       Lflag  uint32
> +       Cc     [20]uint8
> +       Ispeed uint32
> +       Ospeed uint32
> +}
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

mg_ebfe.org

Hi, I already did that some time ago (see changeset 086b6525aea6). Thanks, Michael On Mon, ...

11 years, 6 months ago (2014-01-13 20:47:31 UTC) #3

Hi,

I already did that some time ago (see changeset 086b6525aea6).

Thanks,
	Michael

On Mon, Jan 13, 2014 at 12:34:03PM -0800, Brad Fitzpatrick wrote:
> You'll need to submit a CLA.  See the contributing docs on the website.
> 
> Let us know when you have and we can process it.
> 
> 
> 
> 
> On Mon, Jan 13, 2014 at 12:31 PM, <gnirheg.leahcim@gmail.com> wrote:
> 
> > Reviewers: golang-codereviews,
> >
> > Message:
> > Hello golang-codereviews@googlegroups.com,
> >
> > I'd like you to review this change to
> > https://code.google.com/p/go
> >
> >
> > Description:
> > syscall: add syscall.Termios on freebsd/{386,amd64}
> >
> > Please review this at https://codereview.appspot.com/51580044/
> >
> > Affected files (+25, -0 lines):
> >   M src/pkg/syscall/types_freebsd.go
> >   M src/pkg/syscall/ztypes_freebsd_386.go
> >   M src/pkg/syscall/ztypes_freebsd_amd64.go
> >
> >
> > Index: src/pkg/syscall/types_freebsd.go
> > ===================================================================
> > --- a/src/pkg/syscall/types_freebsd.go
> > +++ b/src/pkg/syscall/types_freebsd.go
> > @@ -18,6 +18,7 @@
> >  #include <dirent.h>
> >  #include <fcntl.h>
> >  #include <signal.h>
> > +#include <termios.h>
> >  #include <stdio.h>
> >  #include <unistd.h>
> >  #include <sys/event.h>
> > @@ -248,3 +249,7 @@
> >  type BpfHdr C.struct_bpf_hdr
> >
> >  type BpfZbufHeader C.struct_bpf_zbuf_header
> > +
> > +// Terminal handling
> > +
> > +type Termios C.struct_termios
> > Index: src/pkg/syscall/ztypes_freebsd_386.go
> > ===================================================================
> > --- a/src/pkg/syscall/ztypes_freebsd_386.go
> > +++ b/src/pkg/syscall/ztypes_freebsd_386.go
> > @@ -443,3 +443,13 @@
> >         User_gen   uint32
> >         X_bzh_pad  [5]uint32
> >  }
> > +
> > +type Termios struct {
> > +       Iflag  uint32
> > +       Oflag  uint32
> > +       Cflag  uint32
> > +       Lflag  uint32
> > +       Cc     [20]uint8
> > +       Ispeed uint32
> > +       Ospeed uint32
> > +}
> > Index: src/pkg/syscall/ztypes_freebsd_amd64.go
> > ===================================================================
> > --- a/src/pkg/syscall/ztypes_freebsd_amd64.go
> > +++ b/src/pkg/syscall/ztypes_freebsd_amd64.go
> > @@ -446,3 +446,13 @@
> >         User_gen   uint32
> >         X_bzh_pad  [5]uint32
> >  }
> > +
> > +type Termios struct {
> > +       Iflag  uint32
> > +       Oflag  uint32
> > +       Cflag  uint32
> > +       Lflag  uint32
> > +       Cc     [20]uint8
> > +       Ispeed uint32
> > +       Ospeed uint32
> > +}
> >
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "golang-codereviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to golang-codereviews+unsubscribe@googlegroups.com.
> > For more options, visit https://groups.google.com/groups/opt_out.
> >

bradfitz

LGTM On Mon, Jan 13, 2014 at 12:31 PM, <gnirheg.leahcim@gmail.com> wrote: > Reviewers: golang-codereviews, > ...

11 years, 6 months ago (2014-01-13 21:57:20 UTC) #4

LGTM



On Mon, Jan 13, 2014 at 12:31 PM, <gnirheg.leahcim@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> syscall: add syscall.Termios on freebsd/{386,amd64}
>
> Please review this at https://codereview.appspot.com/51580044/
>
> Affected files (+25, -0 lines):
>   M src/pkg/syscall/types_freebsd.go
>   M src/pkg/syscall/ztypes_freebsd_386.go
>   M src/pkg/syscall/ztypes_freebsd_amd64.go
>
>
> Index: src/pkg/syscall/types_freebsd.go
> ===================================================================
> --- a/src/pkg/syscall/types_freebsd.go
> +++ b/src/pkg/syscall/types_freebsd.go
> @@ -18,6 +18,7 @@
>  #include <dirent.h>
>  #include <fcntl.h>
>  #include <signal.h>
> +#include <termios.h>
>  #include <stdio.h>
>  #include <unistd.h>
>  #include <sys/event.h>
> @@ -248,3 +249,7 @@
>  type BpfHdr C.struct_bpf_hdr
>
>  type BpfZbufHeader C.struct_bpf_zbuf_header
> +
> +// Terminal handling
> +
> +type Termios C.struct_termios
> Index: src/pkg/syscall/ztypes_freebsd_386.go
> ===================================================================
> --- a/src/pkg/syscall/ztypes_freebsd_386.go
> +++ b/src/pkg/syscall/ztypes_freebsd_386.go
> @@ -443,3 +443,13 @@
>         User_gen   uint32
>         X_bzh_pad  [5]uint32
>  }
> +
> +type Termios struct {
> +       Iflag  uint32
> +       Oflag  uint32
> +       Cflag  uint32
> +       Lflag  uint32
> +       Cc     [20]uint8
> +       Ispeed uint32
> +       Ospeed uint32
> +}
> Index: src/pkg/syscall/ztypes_freebsd_amd64.go
> ===================================================================
> --- a/src/pkg/syscall/ztypes_freebsd_amd64.go
> +++ b/src/pkg/syscall/ztypes_freebsd_amd64.go
> @@ -446,3 +446,13 @@
>         User_gen   uint32
>         X_bzh_pad  [5]uint32
>  }
> +
> +type Termios struct {
> +       Iflag  uint32
> +       Oflag  uint32
> +       Cflag  uint32
> +       Lflag  uint32
> +       Cc     [20]uint8
> +       Ispeed uint32
> +       Ospeed uint32
> +}
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

bradfitz

11 years, 6 months ago (2014-01-13 21:57:40 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=873d664b00ec ***

syscall: add syscall.Termios on freebsd/{386,amd64}

R=golang-codereviews, bradfitz, mg
CC=golang-codereviews
https://codereview.appspot.com/51580044

Committer: Brad Fitzpatrick <bradfitz@golang.org>

Expand All Messages | Collapse All Messages