Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2242)

Issue 5150047: Add touch handling to BrowserEvent, removing from Dragger

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by Andrew Mattie
Modified:
1 year, 7 months ago
Reviewers:
nnaze
Base URL:
http://closure-library.googlecode.com/svn/trunk/
Visibility:
Public.

Description

As reported here[1], the dragger implementation for touch events is broken in
that it doesn't act on the actual event but rather on the relevant touch. The
problem prevents methods like preventDefault and stopPropagation from working
and masks the touch event when it's dispatched in the DragEvent.

This patch removes the touch event handling functionality from dragger and
instead moves it into BrowserEvent.

http://code.google.com/p/closure-library/issues/detail?id=382

[1]
https://groups.google.com/d/topic/closure-library-discuss/0MO-sSKN2YA/discussion

Patch Set 1 #

Patch Set 2 : Resolved conflicts with SVN r1562 #

Total comments: 12

Patch Set 3 : Styling and consistency fixes #

Patch Set 4 : Updated for compatibility w/ SVN r1780 #

Patch Set 5 : Updated for compatibility w/ SVN r2127 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -46 lines) Patch
closure/goog/events/browserevent.js View 1 2 3 4 2 chunks +32 lines, -11 lines 0 comments Download
closure/goog/events/browserevent_test.html View 1 2 3 4 14 chunks +67 lines, -13 lines 0 comments Download
closure/goog/fx/dragger.js View 1 2 3 4 4 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 9
nnaze
http://codereview.appspot.com/5150047/diff/3002/closure/goog/events/browserevent.js File closure/goog/events/browserevent.js (right): http://codereview.appspot.com/5150047/diff/3002/closure/goog/events/browserevent.js#newcode245 closure/goog/events/browserevent.js:245: var relevantTouch; var touch; http://codereview.appspot.com/5150047/diff/3002/closure/goog/events/browserevent.js#newcode256 closure/goog/events/browserevent.js:256: if (!!relevantTouch) drop ...
2 years, 2 months ago #1
Andrew Mattie
http://codereview.appspot.com/5150047/diff/3002/closure/goog/events/browserevent.js File closure/goog/events/browserevent.js (right): http://codereview.appspot.com/5150047/diff/3002/closure/goog/events/browserevent.js#newcode245 closure/goog/events/browserevent.js:245: var relevantTouch; On 2012/02/06 23:54:48, nnaze wrote: > var ...
2 years, 2 months ago #2
Andrew Mattie
Ping. On 2012/02/07 06:50:18, Andrew Mattie wrote: > http://codereview.appspot.com/5150047
2 years, 1 month ago #3
chromaticbum
On 2012/02/28 16:53:02, Andrew Mattie wrote: > Ping. > > On 2012/02/07 06:50:18, Andrew Mattie ...
2 years, 1 month ago #4
Andrew Mattie
Which hunk was rejected? Were you using patch set 3? I was able to download ...
2 years, 1 month ago #5
chromaticbum
Ah, I see. I was using patch set 1. Tohught I had to incrementally apply ...
2 years, 1 month ago #6
chromaticbum
Patch set 3 works fine. On 2012/03/19 21:40:12, chromaticbum wrote: > Ah, I see. > ...
2 years, 1 month ago #7
Andrew Mattie
Updated for compatibility w/ SVN r1780
1 year, 12 months ago #8
Andrew Mattie
1 year, 7 months ago #9
Updated for compatibility w/ SVN r2127
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5