http://codereview.appspot.com/5148046/diff/1/samples/oauth/oauth_example.py File samples/oauth/oauth_example.py (right): http://codereview.appspot.com/5148046/diff/1/samples/oauth/oauth_example.py#n... samples/oauth/oauth_example.py:28: """An OAuthSample object demonstrates the three-legged OAuth process.""" s/An OAuthSample object demonstrates the three-legged OAuth process./Sample class demonstrating the three-legged OAuth process. http://codereview.appspot.com/5148046/diff/1/samples/oauth/oauth_example.py#n... samples/oauth/oauth_example.py:35: Uses HMAC-SHA1 signature method. the constructor doesn't do all of that http://codereview.appspot.com/5148046/diff/1/samples/oauth/oauth_example.py#n... samples/oauth/oauth_example.py:60: i += 1 can this loop be replaced with list.enumerate in order to get the index and the value without having to rely on your counter? http://codereview.appspot.com/5148046/diff/1/samples/oauth/oauth_example.py#n... samples/oauth/oauth_example.py:69: documents using Document List Data API.""" s/Document List Data API/the Document List Data API http://codereview.appspot.com/5148046/diff/1/samples/oauth/oauth_example.py#n... samples/oauth/oauth_example.py:107: '--consumer_secret [consumer_secret] ') be consistent here, use oauth_consumer_key and oauth_consumer_secret or consumer_key and consumer_secret
http://codereview.appspot.com/5148046/diff/5001/samples/oauth/oauth_example.py File samples/oauth/oauth_example.py (right): http://codereview.appspot.com/5148046/diff/5001/samples/oauth/oauth_example.p... samples/oauth/oauth_example.py:18: __author__ = 'kunalmshah.userid (Kunal Shah)' is this your secret identity? http://codereview.appspot.com/5148046/diff/5001/samples/oauth/oauth_example.p... samples/oauth/oauth_example.py:35: Docs List Data API. s/to Docs List Data API/to the Documents List Data API
http://codereview.appspot.com/5148046/diff/1/samples/oauth/oauth_example.py File samples/oauth/oauth_example.py (right): http://codereview.appspot.com/5148046/diff/1/samples/oauth/oauth_example.py#n... samples/oauth/oauth_example.py:28: """An OAuthSample object demonstrates the three-legged OAuth process.""" On 2011/09/29 19:46:01, Claudio Cherubino wrote: > s/An OAuthSample object demonstrates the three-legged OAuth process./Sample > class demonstrating the three-legged OAuth process. Done. http://codereview.appspot.com/5148046/diff/1/samples/oauth/oauth_example.py#n... samples/oauth/oauth_example.py:35: Uses HMAC-SHA1 signature method. On 2011/09/29 19:46:01, Claudio Cherubino wrote: > the constructor doesn't do all of that Done. http://codereview.appspot.com/5148046/diff/1/samples/oauth/oauth_example.py#n... samples/oauth/oauth_example.py:60: i += 1 On 2011/09/29 19:46:01, Claudio Cherubino wrote: > can this loop be replaced with list.enumerate in order to get the index and the > value without having to rely on your counter? Done. http://codereview.appspot.com/5148046/diff/1/samples/oauth/oauth_example.py#n... samples/oauth/oauth_example.py:69: documents using Document List Data API.""" On 2011/09/29 19:46:01, Claudio Cherubino wrote: > s/Document List Data API/the Document List Data API Done. http://codereview.appspot.com/5148046/diff/1/samples/oauth/oauth_example.py#n... samples/oauth/oauth_example.py:107: '--consumer_secret [consumer_secret] ') On 2011/09/29 19:46:01, Claudio Cherubino wrote: > be consistent here, use oauth_consumer_key and oauth_consumer_secret or > consumer_key and consumer_secret Done. http://codereview.appspot.com/5148046/diff/5001/samples/oauth/oauth_example.py File samples/oauth/oauth_example.py (right): http://codereview.appspot.com/5148046/diff/5001/samples/oauth/oauth_example.p... samples/oauth/oauth_example.py:18: __author__ = 'kunalmshah.userid (Kunal Shah)' On 2011/09/29 20:33:38, Claudio Cherubino wrote: > is this your secret identity? This is not my sample App. I don't know who he is. http://codereview.appspot.com/5148046/diff/5001/samples/oauth/oauth_example.p... samples/oauth/oauth_example.py:35: Docs List Data API. On 2011/09/29 20:33:38, Claudio Cherubino wrote: > s/to Docs List Data API/to the Documents List Data API Done.
LGTM