Issue 51460043: Web: Text-input: make LM reference more friendly.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 51460043: Web: Text-input: make LM reference more friendly.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by uliska

Modified:
10 years, 3 months ago

Reviewers:
Graham Percival

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Web: Text-input: make LM reference more friendly. I think putting it this way sounds less defensive or arrogant. I think it is better to combine the two paragraphs because this section was somewhat jaggy.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Incorporate suggestion by Graham #

Patch Set 3 : Incorporate one more suggestion #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	Documentation/web/introduction.itexi	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

uliska

How about that? It doesn't include David's latest suggestions (because I was already ready with ...

10 years, 3 months ago (2014-01-13 13:03:08 UTC) #1

Graham Percival

https://codereview.appspot.com/51460043/diff/1/Documentation/web/introduction.itexi File Documentation/web/introduction.itexi (right): https://codereview.appspot.com/51460043/diff/1/Documentation/web/introduction.itexi#newcode1138 Documentation/web/introduction.itexi:1138: before they come up! Occasionally new users are unnecessarily ...

10 years, 3 months ago (2014-01-16 07:53:40 UTC) #2

uliska

10 years, 3 months ago (2014-01-18 10:10:01 UTC) #5

https://codereview.appspot.com/51460043/diff/1/Documentation/web/introduction...
File Documentation/web/introduction.itexi (right):

https://codereview.appspot.com/51460043/diff/1/Documentation/web/introduction...
Documentation/web/introduction.itexi:1138: before they come up!  Occasionally
new users are unnecessarily
On 2014/01/16 07:53:40, Graham Percival wrote:
> I prefer keeping a paragraph break here, since that makes the next sentence
> easier to see.

Done.

https://codereview.appspot.com/51460043/diff/1/Documentation/web/introduction...
Documentation/web/introduction.itexi:1139: irritated by some aspects of
LilyPond's behaviour.  Please read
On 2014/01/16 07:53:40, Graham Percival wrote:
> I suggest using "unnecessarily confused" rather than "irritated".

Done.

Expand All Messages | Collapse All Messages