Improve machine errors handling.

Improve machine errors handling.

Quickstart no longer hangs when the GUI
machine goes in an "error" state and, as
a consequence, the unit is forever in
a "pending" state.

Also fixed the message printed at the
end of the process suggesting how to
destroy the environment
(sudo is used where required).

Tests: `make check`.

QA: I already asked Rick to reproduce the trusty/LXC
errors he encountered QAing my previous branch.
The GUI no longer hangs.
I'd also appreciate any other suggestion and additional
QA, given that this branch is a good candidate for 1.0.

https://code.launchpad.net/~frankban/juju-quickstart/handle-machine-errors/+merge/202105

(do not edit description out of merge proposal)

[frankban, 2014-01-17 14:06:28]

Please take a look.

[bac, 2014-01-17 15:20:15]

Code LGTM.  Have not yet done QA.

https://codereview.appspot.com/51350044/diff/1/quickstart/app.py
File quickstart/app.py (right):

https://codereview.appspot.com/51350044/diff/1/quickstart/app.py#newcode467
quickstart/app.py:467: # specific unit. For this reason, we exit the for loop
here.
You don't sound convinced.  Any chance that assumption is wrong?  The penalty
for looping over the rest non-matching items is trivial.  But if you're sure,
maybe keep this logic but change the comment to be more confident.

https://codereview.appspot.com/51350044/diff/1/quickstart/app.py#newcode481
quickstart/app.py:481: # We assume the mega-watcher contains a single change for
each
As above.

[frankban, 2014-01-17 15:26:04]

Please take a look.

https://codereview.appspot.com/51350044/diff/1/quickstart/app.py
File quickstart/app.py (right):

https://codereview.appspot.com/51350044/diff/1/quickstart/app.py#newcode467
quickstart/app.py:467: # specific unit. For this reason, we exit the for loop
here.
On 2014/01/17 15:20:15, bac wrote:
> You don't sound convinced.  Any chance that assumption is wrong?  The penalty
> for looping over the rest non-matching items is trivial.  But if you're sure,
> maybe keep this logic but change the comment to be more confident.

Done.

https://codereview.appspot.com/51350044/diff/1/quickstart/app.py#newcode481
quickstart/app.py:481: # We assume the mega-watcher contains a single change for
each
On 2014/01/17 15:20:15, bac wrote:
> As above.

Done.

[rharding, 2014-01-17 17:01:45]

LGTM thanks for the updates and a lot more tests.

[bac, 2014-01-17 17:40:20]

qa-ok, modulo the issue we talked about on IRC.

[frankban, 2014-01-17 18:37:33]

*** Submitted:

Improve machine errors handling.

Quickstart no longer hangs when the GUI
machine goes in an "error" state and, as
a consequence, the unit is forever in
a "pending" state.

Also fixed the message printed at the
end of the process suggesting how to
destroy the environment
(sudo is used where required).

Tests: `make check`.

QA: I already asked Rick to reproduce the trusty/LXC
errors he encountered QAing my previous branch.
The GUI no longer hangs.
I'd also appreciate any other suggestion and additional
QA, given that this branch is a good candidate for 1.0.

R=bac, rharding
CC=
https://codereview.appspot.com/51350044

[frankban, 2014-01-17 18:51:02]

Thank you!