Issue 5124048: Viewport scrolling in Firefox uses the atoms now. Fixed some tests.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5124048: Viewport scrolling in Firefox uses the atoms now. Fixed some tests.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by ahaas

Modified:
12 years, 7 months ago

Reviewers:
Eran

CC:
webdriver-eng_google.com

Visibility:
Public.

Description

The test testDragTooFar does not work with bot.dom.getInViewLocation because this test would move to a negative location on the web page. Now the test moves the element one pixel out of the viewport. The test testMovingMouseBackAndForthPastViewPort did not work because bot.dom.getInViewLocation of coordinates with decimals. I rounded these coorinates.

Patch Set 1 #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -62 lines)			Patch
M	java/client/test/org/openqa/selenium/DragAndDropTest.java	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	java/client/test/org/openqa/selenium/interactions/BasicMouseInterfaceTest.java	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	javascript/firefox-driver/extension/components/firefoxDriver.js	View	3 chunks	+8 lines, -55 lines	0 comments	Download