Simplified 'pub get' step, added make zip target.

Simplified 'pub get' step, added make zip target.

Now make zip will create a new directory zip/ inside pub/ which only contains
the files necessary for inclusion in the packaged app.

Also the requirement for package:browser is removed, as the necessary code is
extracted to js/browser.js. The package:browser/dart.js part of the file has
been modified so that .dart files are replaced in the DOM by .precompiled.dart
files. Also the path is changed to be in js/ instead of lib/src/app.

The next patch will properly removed the duplicate files and fix the build
system so that the app/ directory will not be required.

R=tapted@chromium.org

Committed: https://github.com/tapted/bleeding_edge/commit/415a3e4

[tapted, 2014-01-13 07:46:26]

https://codereview.appspot.com/51210043/diff/40001/dart/sdk/lib/_internal/pub...
File dart/sdk/lib/_internal/pub/app/Makefile (right):

https://codereview.appspot.com/51210043/diff/40001/dart/sdk/lib/_internal/pub...
dart/sdk/lib/_internal/pub/app/Makefile:1: DPATH :=
/Users/tapted/devel/dart-sdk/bin
hm - I'll put up a patch to disappear this, but in a way that `DPATH` will still
be useful

https://codereview.appspot.com/51210043/diff/40001/dart/sdk/lib/_internal/pub...
File dart/sdk/lib/_internal/pub/app/js/main.js (right):

https://codereview.appspot.com/51210043/diff/40001/dart/sdk/lib/_internal/pub...
dart/sdk/lib/_internal/pub/app/js/main.js:15: function DartObject(o) {
ooh - does this mean we can use 

data = DartObject(data);
dest = DartObject(dest);

in archive.js's extractZipFile(..)?

But. Feels really weird to have it in the background page (i.e. main.js, rather
than a .js file included from pub/app/pub.html). It's probably fine to check
that file in directly though.

[pajamallama, 2014-01-14 02:02:24]

https://codereview.appspot.com/51210043/diff/40001/dart/sdk/lib/_internal/pub...
File dart/sdk/lib/_internal/pub/app/js/main.js (right):

https://codereview.appspot.com/51210043/diff/40001/dart/sdk/lib/_internal/pub...
dart/sdk/lib/_internal/pub/app/js/main.js:15: function DartObject(o) {
On 2014/01/13 07:46:27, tapted wrote:
> ooh - does this mean we can use 
> 
> data = DartObject(data);
> dest = DartObject(dest);
> 
> in archive.js's extractZipFile(..)?
> 

Probably not, but I couldn't see the benefit of doing this.

> But. Feels really weird to have it in the background page (i.e. main.js,
rather
> than a .js file included from pub/app/pub.html). It's probably fine to check
> that file in directly though.

Moved this into browser.dart.

[pajamallama, 2014-01-14 06:10:38]

Fixed the description. I need to do further changes but it would make more sense
for them to be in a separate CL.

https://codereview.appspot.com/51210043/diff/40001/dart/sdk/lib/_internal/pub...
File dart/sdk/lib/_internal/pub/app/Makefile (right):

https://codereview.appspot.com/51210043/diff/40001/dart/sdk/lib/_internal/pub...
dart/sdk/lib/_internal/pub/app/Makefile:1: DPATH :=
/Users/tapted/devel/dart-sdk/bin
On 2014/01/13 07:46:27, tapted wrote:
> hm - I'll put up a patch to disappear this, but in a way that `DPATH` will
still
> be useful

Done.

[tapted, 2014-01-14 06:55:34]

lgtm with a nit in browser.js - I'll keenly await the CL with more deleted
files, once the dart->js script tag rewriting is done :)

https://codereview.appspot.com/51210043/diff/40001/dart/sdk/lib/_internal/pub...
File dart/sdk/lib/_internal/pub/app/js/main.js (right):

https://codereview.appspot.com/51210043/diff/40001/dart/sdk/lib/_internal/pub...
dart/sdk/lib/_internal/pub/app/js/main.js:15: function DartObject(o) {
On 2014/01/14 02:02:25, pajamallama wrote:
> On 2014/01/13 07:46:27, tapted wrote:
> > ooh - does this mean we can use 
> > 
> > data = DartObject(data);
> > dest = DartObject(dest);
> > 
> > in archive.js's extractZipFile(..)?
> > 
> 
> Probably not, but I couldn't see the benefit of doing this.

Oh yeah - we'd need the reverse for extractZipFile. Something like 

function FromDartObject(o) {
  if (o.o)
    return o.o;
}

i.e. It's probably something calling this `DartObject` constructor at the wrong
time which is causing extractZipFile to have to deal with arguments coming in
nested in a `DartObject` rather than the object itself.

Anyway - don't worry about this for now.

https://codereview.appspot.com/51210043/diff/70001/dart/sdk/lib/_internal/pub...
File dart/sdk/lib/_internal/pub/app/js/browser.js (right):

https://codereview.appspot.com/51210043/diff/70001/dart/sdk/lib/_internal/pub...
dart/sdk/lib/_internal/pub/app/js/browser.js:14: // Originally from dart
package:browser/dart.js
nit: note how it's locally modified. git helpfully found a file it could `diff`
against :p

[pajamallama, 2014-01-14 07:17:03]

https://codereview.appspot.com/51210043/diff/70001/dart/sdk/lib/_internal/pub...
File dart/sdk/lib/_internal/pub/app/js/browser.js (right):

https://codereview.appspot.com/51210043/diff/70001/dart/sdk/lib/_internal/pub...
dart/sdk/lib/_internal/pub/app/js/browser.js:14: // Originally from dart
package:browser/dart.js
On 2014/01/14 06:55:34, tapted wrote:
> nit: note how it's locally modified. git helpfully found a file it could
`diff`
> against :p

Done.

[pajamallama, 2014-01-14 07:44:29]

Committed patchset #8 manually as r415a3e4 (presubmit successful).