code review 51200045: test: skip SIGCHLD test on Plan 9

test: skip SIGCHLD test on Plan 9

[0intro, 2014-01-29 07:13:27]

Hello jas (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[mikio, 2014-01-29 07:16:26]

https://codereview.appspot.com/51200045/diff/40001/test/sigchld.go
File test/sigchld.go (right):

https://codereview.appspot.com/51200045/diff/40001/test/sigchld.go#newcode1
test/sigchld.go:1: // +build !windows,!plan9
alphanumeric order please

[bradfitz, 2014-01-29 07:37:17]

LGTM
 On Jan 29, 2014 8:13 AM, <0intro@gmail.com> wrote:

> Reviewers: jas,
>
> Message:
> Hello jas (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> test: skip SIGCHLD test on Plan 9
>
> Please review this at https://codereview.appspot.com/51200045/
>
> Affected files (+1, -1 lines):
>   M test/sigchld.go
>
>
> Index: test/sigchld.go
> ===================================================================
> --- a/test/sigchld.go
> +++ b/test/sigchld.go
> @@ -1,4 +1,4 @@
> -// +build !windows
> +// +build !windows,!plan9
>  // cmpout
>
>  // Copyright 2009 The Go Authors. All rights reserved.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[0intro, 2014-01-29 08:27:55]

https://codereview.appspot.com/51200045/diff/40001/test/sigchld.go
File test/sigchld.go (right):

https://codereview.appspot.com/51200045/diff/40001/test/sigchld.go#newcode1
test/sigchld.go:1: // +build !windows,!plan9
On 2014/01/29 07:16:26, mikio wrote:
> alphanumeric order please

Done.

[0intro, 2014-01-29 08:38:21]

*** Submitted as https://code.google.com/p/go/source/detail?r=7e2d24994507 ***

test: skip SIGCHLD test on Plan 9

LGTM=bradfitz
R=jas, mikioh.mikioh, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/51200045

[gobot, 2014-01-29 08:43:55]

This CL appears to have broken the freebsd-386 builder.