code review 51170044: go.tools/oracle: eliminate reliance on undefined map it...

go.tools/oracle: eliminate reliance on undefined map iteration order.

(Unmasked by recent randomization of small (<8) map iteration.)

[adonovan, 2014-01-16 02:21:40]

Hello gri@golang.org, crawshaw@google.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools

[bradfitz, 2014-01-16 02:22:14]

LGTM



On Wed, Jan 15, 2014 at 6:21 PM, <adonovan@google.com> wrote:

> Reviewers: gri, crawshaw1,
>
> Message:
> Hello gri@golang.org, crawshaw@google.com (cc:
> golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.tools
>
>
> Description:
> go.tools/oracle: eliminate reliance on undefined map iteration order.
>
> (Unmasked by recent randomization of small (<8) map iteration.)
>
> Please review this at https://codereview.appspot.com/51170044/
>
> Affected files (+2, -2 lines):
>   M oracle/callgraph.go
>   M oracle/oracle_test.go
>
>
> Index: oracle/callgraph.go
> ===================================================================
> --- a/oracle/callgraph.go
> +++ b/oracle/callgraph.go
> @@ -127,6 +127,7 @@
>                 for callee := range call.CalleesOf(n) {
>                         j.Children = append(j.Children, numbering[callee])
>                 }
> +               sort.Ints(j.Children)
>         }
>         res.Callgraph = cg
>  }
> Index: oracle/oracle_test.go
> ===================================================================
> --- a/oracle/oracle_test.go
> +++ b/oracle/oracle_test.go
> @@ -211,8 +211,7 @@
>                 "testdata/src/main/what.go",
>                 // JSON:
>                 // TODO(adonovan): most of these are very similar; combine
> them.
> -               // TODO(adonovan): enable this test once it works again.
> -               //"testdata/src/main/callgraph-json.go",
> +               "testdata/src/main/callgraph-json.go",
>                 "testdata/src/main/calls-json.go",
>                 "testdata/src/main/peers-json.go",
>                 "testdata/src/main/describe-json.go",
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[crawshaw1, 2014-01-16 03:30:35]

LGTM

[adonovan, 2014-01-16 03:55:53]

*** Submitted as
https://code.google.com/p/go/source/detail?r=327898a95b58&repo=tools ***

go.tools/oracle: eliminate reliance on undefined map iteration order.

(Unmasked by recent randomization of small (<8) map iteration.)

R=gri, crawshaw, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/51170044

[gri, 2014-01-16 05:16:30]

LGTM