Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1649)

Issue 51150044: Remove chown from environ.configstore

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by thumper
Modified:
10 years, 3 months ago
Reviewers:
dimitern, mp+203254
Visibility:
Public.

Description

Remove chown from environ.configstore The chown code was there primarily for the local provider. This is no longer needed (and had a slight bug where it wasn't actually checking to see if the current user was root before trying to chown the files and dirs). The code has simply been removed. I have tested this with another user I have on my laptop and the local provider bootstraps fine. https://code.launchpad.net/~thumper/juju-core/fix-prepare-chown/+merge/203254 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -23 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/configstore/disk.go View 4 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 2
thumper
Please take a look.
10 years, 3 months ago (2014-01-26 19:34:10 UTC) #1
dimitern
10 years, 3 months ago (2014-01-27 00:00:09 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b